manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard

Only wait for ansible-runner pid in run_async

Open agrare opened this issue 3 years ago • 1 comments

Ansible-runner only creates a pid file when running as a daemon in the background. We should only wait for this file to be created when we are running async otherwise it is enough to wait for the ansible-runner command to return.

Follow-up to https://github.com/ManageIQ/manageiq/pull/22046

agrare avatar Aug 09 '22 20:08 agrare

Checked commit https://github.com/agrare/manageiq/commit/5d035755537638c084dd62b0aa52c17d117c6512 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie:

miq-bot avatar Aug 09 '22 20:08 miq-bot

Backported to najdorf in commit ccd74be6fe2584cda61423e4ccbd37d86fd75ed0.

commit ccd74be6fe2584cda61423e4ccbd37d86fd75ed0
Author: Jason Frey <[email protected]>
Date:   Wed Aug 10 09:50:34 2022 -0400

    Merge pull request #22047 from agrare/only_run_wait_for_run_async
    
    Only wait for ansible-runner pid in run_async
    
    (cherry picked from commit b8741cc73b7d0e5849061f7cb3a3bc4a61261950)

Fryguy avatar Aug 10 '22 14:08 Fryguy

Backported to morphy in commit 1ade723c9633f56fd5a516a17b26e6be83bfd601.

commit 1ade723c9633f56fd5a516a17b26e6be83bfd601
Author: Jason Frey <[email protected]>
Date:   Wed Aug 10 09:50:34 2022 -0400

    Merge pull request #22047 from agrare/only_run_wait_for_run_async
    
    Only wait for ansible-runner pid in run_async
    
    (cherry picked from commit b8741cc73b7d0e5849061f7cb3a3bc4a61261950)

Fryguy avatar Nov 16 '22 23:11 Fryguy