manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard

Default to miq_messaging for event_handler

Open nasark opened this issue 3 years ago • 4 comments

  • picking up and continuing from https://github.com/ManageIQ/manageiq/pull/21361
  • set Kafka as the default messaging_type for events

i.e.

nasarkhan@Nasars-MacBook-Pro manageiq % kafka-console-consumer --bootstrap-server localhost:9092 --topic manageiq.ems --from-beginning
{"event_type":"test_action","source":"IBMCloud-VPC","username":"nasar123","ems_id":1,"ems_ref":"abc","timestamp":"1234","vm_uid_ems":"vm","vm_ems_ref":"vm_ref"}
{"ems_ref":"event-ref","ems_id":34000000000941,"event_type":"STUFF_HAPPENED"}

Depends on:

  • [ ] https://github.com/ManageIQ/manageiq-schema/pull/655

@miq-bot assign @agrare @miq-bot add_labels enhancement

nasark avatar Jul 14 '22 20:07 nasark

@miq-bot cross-repo-tests https://github.com/ManageIQ/manageiq-schema/pull/655

nasark avatar Jul 14 '22 20:07 nasark

Checked commits https://github.com/nasark/manageiq/compare/fb404d1ae34586c433bd302ffe2ea2bfef075ff4~...463ea2ed2bee187b76aadcafa7e396b615a91afe with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 6 files checked, 0 offenses detected Everything looks fine. :trophy:

miq-bot avatar Jul 18 '22 17:07 miq-bot

@agrare ready for review

nasark avatar Jul 18 '22 18:07 nasark

I'm wondering if we need the schema changes at all. I don't think there's an expectation of upgrading prototypes as being supported.

Fryguy avatar Jul 19 '22 18:07 Fryguy

Checked commits https://github.com/nasark/manageiq/compare/8d375fcf0f360b253b58eb2e753c237a9feae678~...0797b3a76d947dfcf3787f01e29f2bc4e523e70f with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 5 files checked, 0 offenses detected Everything looks fine. :trophy:

miq-bot avatar Oct 24 '22 15:10 miq-bot