Use supports in more instances

[kbrock]

This is a continuation from https://github.com/ManageIQ/manageiq/issues/21179

We have a number if implementations that are basically a reimplementation of SupportsMixin. Convert these implementations over to using supports

• [ ] convert supports_authentication() to supports
• [ ] convert supports_pxe to supports :pxe along with iso, cloud_init, sysprep, customization_template.
• [ ] remove kind_of? from Button classes.
• [x] https://github.com/ManageIQ/manageiq/pull/22288
• [ ] convert supports :smartstate_analasys to basic implementation (as seen in storage.rb)
• [ ] https://github.com/ManageIQ/manageiq/pull/21990
  • [ ] Add supports :html5_console to providers (instead of deriving it in main - add when you see spice_console, vnc_console, webmks_console. note webmks_console is new for most)
  • [ ] Added supports :console to providers with the same logic.
  • [ ] Drop console_supported? method.
  • [ ] move logic from :launch_html5_console, :launch_native_console, :launch_vmrc_console to supports :{}_console blocks. (make it consistent to check vm for required attributes)
• [x] https://github.com/ManageIQ/manageiq/pull/22578
• [x] #22883
• [x] https://github.com/ManageIQ/manageiq/pull/22751
• [ ] remove check_feature_support(:feature) and replace with supports?(feature) - beware of the false, nil coming back.
• [ ] condense unsupported_reason() unless supports?() => unsupported_reason()
• [ ] storage_type_supported_for_ssa
• [ ] validate_active_with_power_state
• [x] https://github.com/ManageIQ/manageiq/pull/22908

review:

• InventoryRefresh#supports_sti?
• MiqEnvironment#supports_systemd?
• MiqEnvironment#supports_nohup_and_backgrounding
• Flavor#supports_instance_store (virtual column)
• Flavor#supports_ebs
• NetworkManager#supports_security_groups ?
• Button#supports_button_action
• Kubevirt::ProvisionWorkflow#supports_native_clone
• Awx::Dialog supports_limit

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[kbrock]

brought console_supported up to date. adam and I keep coming back to the same solution: convert blocks with complicated logic to a simple supports in the leaf nodes

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.