manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard

[WIP] [POC] Remove multiple server support from the orchestrator process.

Open Fryguy opened this issue 4 years ago • 2 comments

This PR is a PoC to show how we don't need as_each_server at the evm_server level. It probably does not work as is. This is a partial revert of https://github.com/ManageIQ/manageiq/pull/19734

The idea here is that the orchestrator should only be responsible for its own "server". In appliances this is done automatically because we only watch one server anwyay, and we presume the rest of the server records are being watched by their orchestrators. In podified, this was changed to watch every "server", however all of the servers are fake records that are only in place to deal with the zone -> miq_server relationship which we need for zone support.

Instead, what we can do is just watch the one "server" record we care about, and then change the way we monitor other servers in server_monitor.rb. What's missing from this PR is that the server_monitor.rb code needs to change such that we can have a subclass for Kubernetes that effectively does nothing for the other "fake" servers (i.e. we don't care about heartbeats), but still allow for role management to support the zones concept of placement. @agrare had a good idea for a MiqServer::PlatformManagement, which I think aligns with this.

Built on #21532, so only look at the latest commit: https://github.com/Fryguy/manageiq/compare/Fryguy:remove_as_each_server~...Fryguy:remove_as_each_server?expand=1

cc @agrare @jrafanie

Fryguy avatar Nov 02 '21 17:11 Fryguy

Checked commit https://github.com/Fryguy/manageiq/commit/29d751e9d0b9492335a483c1e9c14199ff3eabf4 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :star:

miq-bot avatar Nov 02 '21 18:11 miq-bot

This pull request is not mergeable. Please rebase and repush.

miq-bot avatar Nov 10 '21 16:11 miq-bot

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Feb 27 '23 00:02 miq-bot