manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard

Move schedules#build_search_filter_from_params to core repository

Open lpichler opened this issue 3 years ago • 3 comments

Method build_search_filter_from_params needs to be located in core repository in order to be available also for Schedule API Endpoint..

Method needs to be also refactored.

Approach:

  • [x] 1. Refactor method build_search_filter_from_params in UI so we can easily transfer the method. #7470
  • [x] 2. Add updated method build_search_filter_from_params (+others) to core repository #20763
  • [ ] 3. Refactor related methods in core repository #20764
  • [ ] 4. Remove method build_search_filter_from_params in UI and use method build_search_filter_from_params from core.#7472

lpichler avatar Nov 02 '20 15:11 lpichler

Sorry for the noise Libor. please don't close as this is still important work.

Note to self:

I would like to move this to schedule, but don't want to follow the route of moving the expression into each of the classes but instead put as part of schedule itself.

kbrock avatar Jun 29 '22 15:06 kbrock

@kbrock I am sorry if I closed anything current. Thanks for note!

lpichler avatar Jun 29 '22 15:06 lpichler

@lpichler I haven't said this recently: "you rock"

kbrock avatar Jul 25 '22 18:07 kbrock

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Feb 27 '23 00:02 miq-bot

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar May 29 '23 00:05 miq-bot