manageiq
manageiq copied to clipboard
Move schedules#build_search_filter_from_params to core repository
Method build_search_filter_from_params needs to be located in core repository in order to be available also for Schedule API Endpoint..
Method needs to be also refactored.
Approach:
- [x] 1. Refactor method
build_search_filter_from_params
in UI so we can easily transfer the method. #7470 - [x] 2. Add updated method
build_search_filter_from_params
(+others) to core repository #20763 - [ ] 3. Refactor related methods in core repository #20764
- [ ] 4. Remove method
build_search_filter_from_params
in UI and use methodbuild_search_filter_from_params
from core.#7472
Sorry for the noise Libor. please don't close as this is still important work.
Note to self:
I would like to move this to schedule, but don't want to follow the route of moving the expression into each of the classes but instead put as part of schedule itself.
@kbrock I am sorry if I closed anything current. Thanks for note!
@lpichler I haven't said this recently: "you rock"
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master
, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.
This issue has been automatically closed because it has not been updated for at least 3 months.
Feel free to reopen this issue if this issue is still valid.
Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.