support params for patch

Open grosser opened this issue 6 years ago • 2 comments

atm I'm forced to do this, which is kinda ugly :D

patch_entity("#{name}?fieldManager=kubectl&force=true", template, namespace)

Dec 23 '19 19:12 grosser

Sorry fat finger. Are any of those useful for the 3 patch variants, or just for apply?

(I'm not sure the pattern of kubeclient whitelisting query params per action is useful - it mostly requires people to wait until new param support is added. I wonder if a generic pass-through of unknown params is workable.)

Dec 23 '19 21:12 cben

generic pass-through would be nice ... would mean less abstractions/layers and less changes to kubeclient :) ... idk of other patch versions, so far only needed it for apply

Dec 23 '19 21:12 grosser