kubeclient icon indicating copy to clipboard operation
kubeclient copied to clipboard

serialize labelSelector in get_pods and others

Open grosser opened this issue 9 years ago • 2 comments

get_pods label_selector: {foo: 1} atm results in http://foobar.server/api/v1/namespaces/pod1/pods?labelSelector%5Bfoo%5D=1 ... but should be: http://foobar.server/api/v1/namespaces/pod1/pods?labelSelector=foo%3D1

grosser avatar Dec 13 '16 23:12 grosser

label_selector: 'foo=1' works, right? This would be just sugar? There are 4 selector operators, =, !=, in, notin. How would you represent the other types?

cben avatar Apr 18 '17 10:04 cben

these need to be string ... either turn hash into proper query or blow up with an ArgumentError ... just don't keep the current state of "weird unexpected behavior"

grosser avatar Apr 19 '17 03:04 grosser