integration_tests icon indicating copy to clipboard operation
integration_tests copied to clipboard

[WIP] Move browser management to kaifuku

Open mshriver opened this issue 6 years ago • 4 comments

Use webdriver-kaifuku, replacing most of the code in cfme.utils.browser

remove convenience methods surrounding the manager singleton, and update framework interaction with the browser from that singleton

phase one of changing how integration_tests handles browsers, phase two will be to move the manager instance to the contextual classes for UI/SSUI

PRT

Currently UI tests are failing with a screenshot showing the login screen, with no credentials filled. cfme.log shows navigation, form fill, and button click, needs local debug.

mshriver avatar Mar 17 '20 18:03 mshriver

@mshriver I'm itching to try it in one of my projects. did you make it work in integration tests ?

izapolsk avatar Mar 31 '20 14:03 izapolsk

@izapolsk Ronny just merged my PRs and released 0.3.0, worth a try on any projects you're working on. I just rebased this and will be testing it.

mshriver avatar May 26 '20 11:05 mshriver

I detected some fixture changes in commit 0579fbd0b75b56403ce0bee1ba73e2a9860ae363

The local fixture needs_firefox is used in the following files:

  • cfme/tests/services/test_myservice.py
    • test_download_file

The local fixture generated_request is used in the following files:

  • cfme/tests/services/test_operations.py
    • test_services_request_direct_url
    • test_copy_request

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage :smiley:

dajoRH avatar May 26 '20 12:05 dajoRH

Would you mind rebasing this Pull Request against latest master, please? :trollface: CFME QE Bot

dajoRH avatar Jun 05 '20 14:06 dajoRH