integration_tests icon indicating copy to clipboard operation
integration_tests copied to clipboard

[WIP]Implemented automated test for add_provider_with_instance_without_name

Open mmojzis opened this issue 5 years ago • 3 comments

{{ pytest: -k "test_add_provider_with_instance_without_name" -v }}

mmojzis avatar Jan 09 '20 14:01 mmojzis

I detected some fixture changes in commit 1ef91803e8c3886b39113d78c82831df2bad3387

The local fixture instance_without_name is used in the following files:

  • cfme/tests/cloud/test_providers.py
    • test_add_provider_with_instance_without_name

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage :smiley:

dajoRH avatar Jan 20 '20 15:01 dajoRH

Would you mind rebasing this Pull Request against latest master, please? :trollface: CFME QE Bot

dajoRH avatar Feb 07 '20 18:02 dajoRH

@kedark3 @john-dupuy @mshriver So I would like to make this PR merged. The problem is that create_vm by default doesn't handle vm without name. I tried to use _create_vm(), but it didn't work as wrapanapi had no identificator for vm - by default it's name, but when instance doesn't have name it's identified by uuid, but _create_vm doesn't provide one. As I am leaving by the end of this month I would like to make this PR merged without using create_vm. I could try to fix the issue, but it would take me probably a lot of time and I don't see the point to use create_vm as it's premise is AFAIK that every VM created by this method has test assignee as a suffix in its name, which cannot be applied for this specific test. Thanks for feedback.

mmojzis avatar Apr 14 '20 14:04 mmojzis