integration_tests icon indicating copy to clipboard operation
integration_tests copied to clipboard

[WIP] Dynaconf for yamls

Open kedark3 opened this issue 6 years ago • 5 comments

Purpose or Intent

This PR is an enhancement of what I have done in PR #9315 as it is able to read values for all the available yamls in conf/ directory.

It does have limitations though(dynaconf imposed):

  1. It cannot override and merge values from .local.yaml files [Update] I have a PR that may fix the issue number 1 listed above: https://github.com/rochacbruno/dynaconf/pull/238 - waiting on them to release new version
  2. It does not have a property runtime as the conf had [Update] I have made it possible to mimic the runtime property with dynaconf and it seems to collect alright locally.

You still need my latest GitLab PR to make this code work locally.

File names _copy are not final, will rename files before merge.

kedark3 avatar Sep 18 '19 19:09 kedark3

@john-dupuy yes please pull my YAMLs PR 832 and then you can run:

In [1]: from cfme.utils import conf_copy                                                                               
In [2]: conf_copy.cfme_data                                                                                            
Out[2]: <cfme.utils.config_copy.ConfigData at 0x7f9aa6e7c1d0>

In [3]: conf_copy.cfme_data.basic_info <or any other keys>

kedark3 avatar Sep 19 '19 20:09 kedark3

I am waiting on my Dynaconf PR before working on this one. In the meanwhile feel free to leave reviews. I will fix travis later.

kedark3 avatar Sep 23 '19 17:09 kedark3

Moving to WIPTEST based off of https://github.com/ManageIQ/integration_tests/pull/9376#issuecomment-534193018, let me know if you'd like to leave it RFR @kedark3

john-dupuy avatar Sep 24 '19 11:09 john-dupuy

To Reviewers: This PR passed the jenkins run, I can point you to it if needed.Kindly review.

kedark3 avatar Oct 09 '19 19:10 kedark3

Would you mind rebasing this Pull Request against latest master, please? :trollface: CFME QE Bot

dajoRH avatar Oct 16 '19 16:10 dajoRH