[WIPTEST] Add type annotations

[jarovo]

Purpose or Intent

Enhancement of type annotations will help to discover type errors and write the code with autocompleting editor.

Also, some typos were corrected.

[dajoRH]

I detected some fixture changes in commit 068b5d2d6b95af6352be95d34288334a23271125

Show fixtures

The global fixture temp_appliance_preconfig_modscope is used in the following files:

• cfme/tests/cli/test_appliance_cli.py
  • test_appliance_console_cli_timezone
• cfme/tests/cli/test_appliance_console.py
  • test_appliance_console_set_timezone
  • test_appliance_console_network_conf_negative
  • test_appliance_console_shutdown
  • test_appliance_console_static_ip_negative

The global fixture temp_appliance_preconfig_clsscope was changed, but I didn't find where it's used. The global fixture temp_appliance_preconfig_funcscope is used in the following files:

• cfme/tests/cli/test_appliance_cli.py
  • test_appliance_console_cli_datetime
• cfme/tests/cli/test_appliance_console.py
  • test_appliance_console_datetime
  • test_appliance_console_internal_db_reset
  • test_appliance_console_restart
  • test_appliance_console_evm_stop
  • test_appliance_console_evm_start
  • test_appliance_console_vmdb_httpd
  • test_appliance_console_restore_db_network_negative
  • test_appliance_console_key_fetch_negative
  • test_ap_failed_dbconfig_status
  • test_appliance_console_vmdb_log_negative
• cfme/tests/cli/test_appliance_console_db_restore.py
  • get_appliance_with_ansible
• cfme/tests/cli/test_appliance_log_rotate.py
  • test_appliance_log_rotate
• cfme/tests/configure/test_register_appliance.py
  • appliance_preupdate
• cfme/tests/intelligence/reports/test_canned_corresponds.py
• cfme/tests/test_db_migrate.py
  • temp_appliance_remote
• cfme/tests/webui/test_general_ui.py

The global fixture temp_appliance_preconfig_funcscope_upgrade is used in the following files:

• cfme/tests/test_db_migrate.py
  • appliance_preupdate

The global fixture temp_appliance_preconfig_long is used in the following files:

• cfme/tests/cli/test_appliance_console.py
  • secondary_dns
  • test_appliance_console_network_conf
  • test_appliance_console_static_dns
• cfme/tests/integration/test_aws_iam_auth_and_roles.py
  • test_group_roles
• cfme/tests/integration/test_cfme_auth.py
  • user_obj
  • log_monitor
  • retrieve_group
  • local_group
  • local_user
  • do_not_fetch_remote_groups
  • test_login_local_group
• cfme/tests/integration/test_ldap_auth_and_roles.py
  • test_group_roles

The global fixture temp_appliance_preconfig_funcscope_rhevm was changed, but I didn't find where it's used. The global fixture temp_appliance_unconfig_modscope was changed, but I didn't find where it's used. The global fixture temp_appliance_unconfig_clsscope was changed, but I didn't find where it's used. The global fixture temp_appliance_unconfig_funcscope is used in the following files:

• cfme/tests/cli/test_appliance_cli.py
• cfme/tests/cli/test_appliance_console.py
  • test_appliance_console_external_db

The global fixture temp_appliance_unconfig_funcscope_rhevm is used in the following files:

• cfme/tests/test_db_migrate.py
  • temp_appliance_global_region

The global fixture temp_appliances_unconfig_modscope was changed, but I didn't find where it's used. The global fixture temp_appliances_unconfig_funcscope_rhevm is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py
  • get_appliances_with_providers
  • get_ext_appliances_with_providers

The global fixture temp_appliances_preconfig_funcscope is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py
  • two_appliances_one_with_providers

The global fixture temp_appliances_unconfig_clsscope was changed, but I didn't find where it's used. The global fixture temp_appliances_unconfig_funcscope was changed, but I didn't find where it's used. The global fixture unconfigured_appliance is used in the following files:

• cfme/tests/cli/test_appliance_cli.py
  • test_appliance_console_cli_internal_fetch_key
  • test_appliance_console_cli_extend_storage
  • test_appliance_console_cli_extend_log_storage
  • test_appliance_console_cli_configure_dedicated_db
• cfme/tests/cli/test_appliance_console.py
  • test_appliance_console_internal_db
  • test_appliance_console_dedicated_db
  • test_appliance_console_extend_storage
  • test_appliance_console_dhcp
  • test_appliance_console_static_ipv4
  • test_appliance_console_static_ipv6
  • test_appliance_overwrite_ssl_ipa
• cfme/tests/test_replication.py
  • setup_replication
  • test_replication_appliance_set_type_global_ui

The global fixture unconfigured_appliance_secondary is used in the following files:

• cfme/tests/cli/test_appliance_cli.py
• cfme/tests/cli/test_appliance_console.py

The global fixture configured_appliance is used in the following files:

• cfme/tests/cli/test_appliance_cli.py
  • test_appliance_console_cli_set_hostname
  • test_appliance_console_cli_external_auth
  • no_ipa_config
  • test_appliance_console_cli_ipa
• cfme/tests/cli/test_appliance_console.py
  • test_appliance_console_set_hostname
  • test_appliance_console_ipa
  • test_appliance_console_external_auth
  • test_appliance_console_external_auth_all
• cfme/tests/test_replication.py
  • setup_replication
  • test_replication_appliance_set_type_global_ui
  • test_replication_subscription_revalidation_pglogical

The global fixture appliance_preupdate was changed, but I didn't find where it's used. The global fixture multiple_preupdate_appliances was changed, but I didn't find where it's used. The global fixture ha_multiple_preupdate_appliances was changed, but I didn't find where it's used.

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage :smiley: