integration_tests icon indicating copy to clipboard operation
integration_tests copied to clipboard
verified publisher icon ManageIQ

[WIP] Add ComparableMixin to InfraVMsCollection and add compare vms test utilizing the mixin.

Open prichard77 opened this issue 5 years ago • 3 comments

Purpose or Intent

  • __Adding tests__to utilize ComparableMixin for VM Collections. This contains commits from PR#9912

PRT Run

prichard77 avatar Apr 15 '20 01:04 prichard77

I detected some fixture changes in commit a02a91aa2affd1285621bffce94a2940445cca5d

The local fixture setup_provider_min_vms is used in the following files:

  • cfme/tests/infrastructure/test_vm_compare.py
    • test_compare_vms

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage :smiley:

dajoRH avatar Apr 15 '20 15:04 dajoRH

Lint report for commit a02a91aa2affd1285621bffce94a2940445cca5d:

cfme/tests/infrastructure/test_providers.py:

  • :bangbang: Line 535:1: E302 expected 2 blank lines, found 1

Please, rectify these issues :smirk: .

No commit flaws detected.

CFME QE Bot

dajoRH avatar Apr 15 '20 15:04 dajoRH

Would you mind rebasing this Pull Request against latest master, please? :trollface: CFME QE Bot

dajoRH avatar May 12 '20 17:05 dajoRH