Pavel Solodovnikov
Pavel Solodovnikov
Force-pushed the branch to fix the problem discovered by @chriku. `SteamNetworkingIdentityToProtobuf` macro will attempt to perform a compile-time check to see if `msg.GetTypeName()` returns `std::string` or not (in this case,...
@chriku Sure, you're absolutely right. This is an exceptional path, so indeed there's no need for extra typing to avoid a string copy. I'll post a fix a bit later....
Force-pushed the branch to implement the suggestion from @chriku to simplify the code. Also added a brief explanation about code safety with respect to the latest C++ standard draft.
Yep. That's the reason I've provided a thorough comment so that it doesn't make anyone looking at the code to raise an eyebrow. I think I've been writing like that...
#4300 was a prerequisite to fix this issue. Now that this is fixed, we can finally re-evaluate the code base and remove extra message copies by moving the message from...