Pavel Solodovnikov
Pavel Solodovnikov
@westonpace @pitrou Polite review ping.
Force-pushed the branch to address review comments from @westonpace. The diff can be found here: https://github.com/apache/arrow/compare/e91396ccf22eec394f23369255a9fd65be60b274..a6c5d5075b8150cf4ecf6874ad59a0e8497af93c Changelog: * Added a non-virtual `GetFragmentsAsyncImplBase`, which accepts a `arrow::internal::Executor*` which is used as...
Force-pushed the branch to address review comments. The diff can be found there: https://github.com/apache/arrow/compare/a6c5d5075b8150cf4ecf6874ad59a0e8497af93c..b47679f0708ed736e75c0254f5654cae9d9abbe4 Changelog: * Fixed include style, reordered includes * `GetFragmentsAsyncImpl()` accepts a `executor` argument, defaulting to `GetCPUThreadPool()`...
@westonpace @pitrou Polite review ping.
Force-pushed the branch to fix formatting issues reported by an automated CI check. The diff can be found here: https://github.com/facebookincubator/velox/compare/2f94dc4b8cae767d269729cc84a952242c98defe..a739862ff0d9c56d22b4cce79a69ea465d5908f1
Force-pushed (rebase to `main`) to resolve conflicts. @kgpai Polite review ping.
Review ping^2.
Review ping^3. The benchmark regressions surely are unrelated to the change. Is there anything else to be done to make progress with this?
`linux-adapters` CI build failures seems to be unrelated to the patchset (failed to instal minio). Is there anything else needed from my side to push this change forward?
Force-pushed the branch: rebase to `origin/main`.