George Mamadashvili

Results 157 comments of George Mamadashvili

I also tried to debug this issue but wasn't able to find the solution. It looks like tests started failing on the trunk after #34731. Based on artifact Preview dropdown...

The `BlockList` is used in a few other places like Previews. Does it make sense to run the side-effect in those cases where we don't render Inserter?

Server-side preloading comes with the cost of increasing TTFB. I think it mostly depends on how critical the data is.

Maybe we can have something similar to SWR's `preload` helper - https://swr.vercel.app/docs/prefetching.

Any reason for not calculating `isDistractioFree` value during the render? Something like this: ```js const isDistractionFree = isDistractionFreeMode && isLargeViewport ``` Edit: This isn't a blocker.

I can start working on this probably next week. @jasmussen, one question regarding the mockups. What options should be available in the "Ellipsis" dropdown?

@ndiego, do you see any errors in the DevTools console when testing this branch, with or without the core patch? I think failing E2E tests are related to the changes...

First of all, sorry for the mass ping. I've updated the PR description with a detailed list[^1] of PHP changes that need backporting to [wordpress-develop](https://github.com/WordPress/wordpress-develop) in order to be included...