gensen icon indicating copy to clipboard operation
gensen copied to clipboard

Is the GRU implementation in consistent with the paper?

Open my-yy opened this issue 7 years ago • 0 comments

I read the peephole GRU implementation in models.py :

newgate = F.tanh(i_n + resetgate * h_n + p_n) (line54) hy = newgate + inputgate * (hidden - newgate) . (line 55 )

Are they in consistent with the (3) and (4) equations in the paper? I think the line 54 missed the “entrywise product of r_t and h_t-1” and the line 55 also not looks like the equation (4).

my-yy avatar Dec 24 '18 10:12 my-yy