Daniel Mallorga

Results 155 comments of Daniel Mallorga

> The functionality is correct for databases H2, PostgreSQL and MSSQL. I think it's safe to assume it will work in general. The print statements are still present, so they...

I think this could have been already fixed by a recent change. @tati-qalified could you please try again with the latest version?

Hi @robinjhector, We prefer going with the Alternative 1 option. Do you mind listing here the pros/cons of each option just for clarification and an easy decision for everyone? Thanks,...

Hi @robinjhector, Totally agree with you on this statement: > These are just the ones I can think of off the top of my head. I would say implementing this...

Hi @robinjhector, Just wanted to check if there is anything we can help you with. If there are any questions/concerns please don't hesitate to contact us. Thanks, Daniel.

Hi @cornerman, This one also overall looks good to me, but if you can add some unit tests that would be great. There is one thing to fix in this...

Hi @cornerman, Have you had a chance to update this PR? Thanks, Daniel.

Hi @Guschtel, Your proposed code change looks good to me. Please go ahead and apply these changes when you wish. I think it would be nice to also add some...

@filipelautert I saw this jdbc version has a vulnerability associated: I think we can skip this version upgrade.