Daniel Mallorga

Results 155 comments of Daniel Mallorga

Hi @cornerman, Also, thank you for this PR. Code change looks good to me, but again it would be nice if we could add some unit tests. Can you please...

> Hej @MalloD12, > > Agree that the `isMultiple` is confusing, but I am not sure, we should do the change to check for cardinality, because the method is used...

Hey @tati-qalified, Would you mind testing this SQLite fix? Thanks, Daniel.

Thank you, @tati-qalified! Since @cornerman is not keen to keep working and move forward with this PR I think we can just leave in the current state until someone else...

Hi @cornerman, From what we have been discussing with the team yesterday the metadata issue seems to be a SQLite limitation and fixing it would require a considerable amount of...

Hi @cornerman, Yeap, we are fine with your proposal addressing this issue in the way you described above. Feel free to create a PR for it, we will be happy...

Hi @JulienMa94, Thank you for creating this PR, I like this enhancement. I think overall code changes look good to me, but performing a bit of manual testing I noticed...

> Hi @MalloD12, > > thx for your review I will look into this cases as soon I will have some time & add additional test cases 👍🏼 > >...

> Hi @MalloD12, > > I was able to reproduce the mentioned case above for table-exists, view-exists and also for the existing precondition sqlCheck. This behaviour occured because no Regex...