paradox icon indicating copy to clipboard operation
paradox copied to clipboard

paradox-execute.el:290:30:Warning: variable reference to constant ‘nil’

Open gabor-braun opened this issue 5 years ago • 0 comments

Byte-compiling produces the following warning:

In paradox--menu-execute-1: paradox-execute.el:290:30:Warning: variable reference to constant ‘nil’

IMHO, the line number is a bit off, and the issue is by the following lines:

(push (tabulated-list-get-id)
      (pcase c  
        (`?D delete-list)
        (`?I install-list)))

where it is unclear where the new element should be pushed to if c is neither ?D nor ?I.

Emacs expands the lines to

(let* ((v (tabulated-list-get-id)))
  (cond ((eq c 68)
         (setq delete-list (cons v delete-list)))
        ((eq c 73)
         (setq install-list (cons v install-list)))
        (t (setq nil (cons v nil)))))

where the (setq nil ...) is definitely wrong.

gabor-braun avatar Apr 01 '19 20:04 gabor-braun