Rtc icon indicating copy to clipboard operation
Rtc copied to clipboard

Method RtcDateTime::InitWithIso8601(const char* date) does NOT scan ISO8601 but rather RFC1123

Open brewmanz opened this issue 3 years ago • 1 comments

Describe the bug Your commented example is "Sat, 06 Dec 2009 12:34:56 GMT", which is RFC1123. ISO8601 (which has many formats) would be more like "2009-12-06T12:34:56" or "2009-12-06T12:34:56+00:00" or "2009-12-06T12:34:56Z".

To Reproduce I just saw the code.

Expected behavior Either parse according to some ISO8601 format, or be renamed to InitWithRfc1123.

Development environment (please complete the following information): All.

Minimal Sketch that reproduced the problem: Use eyeball MkI.

Additional context None.

brewmanz avatar May 28 '21 02:05 brewmanz

@techi602 provided this support.

Makuna avatar May 30 '21 16:05 Makuna

InitWithIso8601 is now deprecated method. It has been replaced with InitWithDateTimeFormatString which allows the sketch author to provide a formatting string that defines how to covert the string.

Makuna avatar Jun 07 '23 17:06 Makuna

v2.4.0

Makuna avatar Jun 07 '23 17:06 Makuna