Tyler.jl icon indicating copy to clipboard operation
Tyler.jl copied to clipboard

Throttle by render tick so recording is smooth

Open asinghvi17 opened this issue 5 months ago • 6 comments

This way throttling only happens in an interactive context.

asinghvi17 avatar Jul 22 '25 10:07 asinghvi17

I cannot tell the difference on the recorded animation (I compared the one on dev to this one), however, something else catch my eye, in this PR (left) the tiles are more opaque than the ones in dev (right), did something changed with Shading? (or maybe is just me 😄 ).

Screenshot 2025-07-22 at 16 33 25

lazarusA avatar Jul 22 '25 14:07 lazarusA

Hmm could be they are more detailed?

But I will create a test case and put it up

asinghvi17 avatar Jul 22 '25 14:07 asinghvi17

Also here:

Screenshot 2025-07-22 at 16 42 06

This might more a makie thing change ? color handling is different, even for letters, and maybe nothing to do from our side.

lazarusA avatar Jul 22 '25 14:07 lazarusA

I have a hard time seeing the differences, but the text looking "bolder" is in the range of visual changes that v0.24 brought with it. The right looks a bit sharper here right? image image I hope the right one is v0.24? Or is this this PR vs Tyler master with the same makie version?

SimonDanisch avatar Jul 22 '25 16:07 SimonDanisch

is this this PR vs Tyler master with the same makie version. (there should not be any differences, I'm lost now)

lazarusA avatar Jul 22 '25 16:07 lazarusA

In the images from both docs they have an RMSE of 0...there is no difference. I checked with imagemagick.

But I just realized that the tile loading code is itself asynchronous, so this makes no difference. We should add a callback on each OneTimeRenderTick that forces wait(m) before the rendering happens. That should be a kwarg to Map and universal to all axes. This is probably still needed for that though because it triggers the tile recomputation.

asinghvi17 avatar Jul 22 '25 21:07 asinghvi17