Makie.jl icon indicating copy to clipboard operation
Makie.jl copied to clipboard

Published 20 hours ago • verified publisher icon MakieOrg

scroll text if width of Textbox is exceeded

Open bjarthur opened this issue 1 year ago • 9 comments

Description

Fixes https://github.com/MakieOrg/Makie.jl/issues/4268

Type of change

  • [x] New feature (non-breaking change which adds functionality)

Checklist

  • [x] Added an entry in CHANGELOG.md (for new features and breaking changes)
  • [ ] Added unit tests for new algorithms, conversion methods, etc.
  • [ ] Added reference image tests for new plotting functions, recipes, visual options, etc.

bjarthur avatar Aug 30 '24 18:08 bjarthur

not sure how to add a test. happy to do so if someone suggests a way

bjarthur avatar Aug 30 '24 18:08 bjarthur

again, could i please get a review? here's demo code and a movie of the amazing new functionality this PR offers to Makie :)

julia> using GLMakie

julia> f = Figure()

julia> Textbox(f[1,1], width=100)

https://github.com/user-attachments/assets/ff19fe50-c6dd-499c-8fbe-4b9f34b8c8ce

bjarthur avatar Sep 16 '24 13:09 bjarthur

thanks for the suggestion regarding the implementation! i have refactored to use translate and indeed it is much more understandable. working on tests...

bjarthur avatar Oct 01 '24 16:10 bjarthur

i have added visual reference tests, but am having trouble uploading them. when i click on "Update reference images with selection", a popup appears with a "v0.21.0" tag. irrespective of whether i stick with that or choose another (e.g. "v0.22.0", or "master") i get an error on the julia REPL. is this because i don't have write permissions to the required repo?

bjarthur avatar Oct 02 '24 21:10 bjarthur

Yes you need commit rights to use the reference updater. Contributors can only add new test code which notifies committers in the PR status that new images are needed

jkrumbiegel avatar Oct 03 '24 04:10 jkrumbiegel

thanks @jkrumbiegel for the info. let me finish the tests and i'll ping you for another review.

bjarthur avatar Oct 03 '24 12:10 bjarthur

ready for review again.

codecov must not consider the reference tests as those three lines are definitely used there

bjarthur avatar Oct 03 '24 13:10 bjarthur

the ReferenceTests report that "Violin plots differently scaled.png" is different. how could that possibly be?

bjarthur avatar Oct 16 '24 13:10 bjarthur

That's not a problem of the pr ;) we've been updating the reference images and there's likely a Missmatch

SimonDanisch avatar Oct 16 '24 13:10 SimonDanisch

Thanks :)

SimonDanisch avatar Oct 21 '24 11:10 SimonDanisch