don't remove underlying VideoStream file when doing save()

[aplavin]

trafficstars

Description

For some reason, the file was removed when calling save(path, ::VideoStream). This breaks all following show calls: they, clearly, rely on the video file still being present.

Type of change

Delete options that do not apply:

• [x] Bug fix (non-breaking change which fixes an issue)

[SimonDanisch]

Hm, that was a lazy clean up, assuming that one records a video and then when saving it, it isn't needed anymore. I think we'll need to move this into a finalizer for VideoStream to not have this accumulate.

[aplavin]

Hm, I don't think Julia has finalizers for regular structs... Should we make it mutable struct then?

[SimonDanisch]

Yes, I guess we'll need to do that then ;)

[aplavin]

bump... would be nice to fix this

[SimonDanisch]

Thank you!