Makie.jl icon indicating copy to clipboard operation
Makie.jl copied to clipboard

Small fixes

Open SimonDanisch opened this issue 1 year ago • 1 comments

  • fixes picking for WGLMakie on high dpi screens
  • Fixes that some attributes are not correctly applied when returning PlotSpec in convert_arguments
  • Fix map_latest, which hasn't been working so far

TODO:

  • investigate if picking in WGLMakie works correctly now
  • Add tests

SimonDanisch avatar Feb 16 '24 11:02 SimonDanisch

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.51s (3.49, 3.52) 0.01+- 405.75ms (401.32, 413.36) 4.31+- 487.18ms (479.87, 493.95) 5.31+- 7.54ms (7.45, 7.81) 0.13+- 26.17ms (25.95, 26.39) 0.15+-
master 3.51s (3.48, 3.53) 0.02+- 413.40ms (398.14, 431.76) 11.76+- 496.37ms (481.77, 538.97) 19.79+- 7.71ms (7.51, 7.85) 0.10+- 26.16ms (25.94, 26.53) 0.22+-
evaluation 1.00x invariant, -0.0s (-0.05d, 0.92p, 0.02std) 1.02x invariant, -7.65ms (-0.86d, 0.15p, 8.04std) 1.02x invariant, -9.19ms (-0.63d, 0.27p, 12.55std) 1.02x faster ✓, -0.17ms (-1.44d, 0.02p, 0.11std) 1.00x invariant, 0.01ms (0.06d, 0.92p, 0.18std)
CairoMakie 3.03s (3.01, 3.06) 0.02+- 317.15ms (312.96, 322.33) 3.62+- 140.59ms (138.08, 142.73) 1.81+- 7.25ms (7.05, 7.68) 0.25+- 604.98μs (602.95, 607.67) 1.77+-
master 3.03s (2.99, 3.08) 0.03+- 325.36ms (315.28, 344.03) 9.54+- 143.78ms (138.96, 148.41) 3.12+- 7.28ms (7.16, 7.39) 0.08+- 610.15μs (606.52, 614.85) 2.55+-
evaluation 1.00x invariant, -0.0s (-0.14d, 0.80p, 0.03std) 1.03x invariant, -8.21ms (-1.14d, 0.07p, 6.58std) 1.02x faster ✓, -3.19ms (-1.25d, 0.04p, 2.47std) 1.00x invariant, -0.03ms (-0.16d, 0.78p, 0.16std) 1.01x faster ✓, -5.16μs (-2.35d, 0.00p, 2.16std)
WGLMakie 3.82s (3.71, 3.90) 0.06+- 342.69ms (330.95, 351.72) 7.73+- 9.39s (9.22, 9.58) 0.12+- 9.89ms (9.61, 10.18) 0.20+- 69.05ms (68.51, 71.04) 0.91+-
master 3.81s (3.75, 3.92) 0.07+- 336.53ms (328.99, 346.33) 5.97+- 9.31s (9.16, 9.57) 0.14+- 10.02ms (9.66, 10.88) 0.44+- 72.38ms (68.98, 91.52) 8.44+-
evaluation 1.00x invariant, 0.0s (0.06d, 0.92p, 0.07std) 0.98x invariant, 6.17ms (0.89d, 0.12p, 6.85std) 0.99x invariant, 0.08s (0.66d, 0.24p, 0.13std) 1.01x invariant, -0.13ms (-0.38d, 0.50p, 0.32std) 1.05x invariant, -3.32ms (-0.55d, 0.34p, 4.68std)

MakieBot avatar Feb 16 '24 11:02 MakieBot