Makie.jl icon indicating copy to clipboard operation
Makie.jl copied to clipboard

breaking release v0.18

Open SimonDanisch opened this issue 2 years ago • 1 comments

TODO

  • [ ] wait for all changes to get merged (timed release?)
  • [ ] make sure NEWS.md mentions all changes, has good enough guides for upgrading to new changes
  • [ ] up versions
  • [x] enable rebase & merge for the breaking-release branch, so that we don't squish all the merged PRs

Merged changes so far

  • Don't use data_limits to figure out axis type #1770.
  • Clean up conversion pipeline #1810.
  • Clean up Attribute constructor & indexing code 1930.

SimonDanisch avatar May 12 '22 10:05 SimonDanisch

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 21.75s (21.36, 22.35) 0.33+- 26.67s (26.04, 27.06) 0.37+- 22.90s (22.53, 23.20) 0.29+- 31.44ms (30.45, 32.81) 0.84+- 113.75ms (110.89, 116.56) 2.30+-
master 23.29s (22.98, 23.57) 0.20+- 28.49s (28.12, 28.85) 0.27+- 23.38s (22.00, 23.99) 0.67+- 27.04ms (26.11, 28.27) 0.88+- 112.43ms (110.41, 114.64) 1.61+-
evaluation -7.07%, -1.54s faster✅ (-5.68d, 0.00p, 0.26std) -6.83%, -1.82s faster✅ (-5.63d, 0.00p, 0.32std) -2.08%, -0.48s invariant (-0.93d, 0.12p, 0.48std) +14.01%, 4.4ms slower❌ (5.12d, 0.00p, 0.86std) +1.16%, 1.32ms invariant (0.66d, 0.24p, 1.96std)
CairoMakie 13.75s (13.54, 14.11) 0.20+- 18.67s (18.58, 18.90) 0.12+- 2.45s (2.40, 2.53) 0.04+- 19.48ms (19.08, 19.78) 0.27+- 24.51ms (24.29, 24.82) 0.18+-
master 15.10s (14.78, 15.45) 0.22+- 19.68s (19.40, 20.07) 0.24+- 2.46s (2.42, 2.50) 0.03+- 16.15ms (15.92, 16.42) 0.16+- 24.49ms (24.29, 24.68) 0.14+-
evaluation -9.85%, -1.35s faster✅ (-6.32d, 0.00p, 0.21std) -5.41%, -1.01s faster✅ (-5.43d, 0.00p, 0.18std) -0.29%, -0.01s invariant (-0.19d, 0.73p, 0.04std) +17.09%, 3.33ms slower❌ (14.95d, 0.00p, 0.22std) +0.09%, 0.02ms invariant (0.14d, 0.80p, 0.16std)
WGLMakie 18.70s (18.57, 18.87) 0.12+- 31.32s (30.95, 31.59) 0.23+- 44.43s (43.86, 45.72) 0.61+- 23.88ms (23.20, 24.10) 0.32+- 1.66s (1.64, 1.75) 0.04+-
master 19.83s (19.55, 19.94) 0.15+- 33.54s (33.19, 33.90) 0.21+- 44.89s (44.30, 45.55) 0.42+- 19.46ms (18.92, 20.26) 0.50+- 1.65s (1.62, 1.67) 0.02+-
evaluation -6.09%, -1.14s faster✅ (-8.48d, 0.00p, 0.13std) -7.08%, -2.22s faster✅ (-9.97d, 0.00p, 0.22std) -1.05%, -0.47s invariant (-0.89d, 0.13p, 0.51std) +18.50%, 4.42ms slower❌ (10.47d, 0.00p, 0.41std) +0.79%, 0.01s invariant (0.45d, 0.43p, 0.03std)

MakieBot avatar Jun 22 '22 12:06 MakieBot