add new theme.

[lazarusA]

Description

Add a description of your PR here.

This is a new theme, theme_makie :D, since I don't want to change the current defaults. Why theme_makie? the first 3 colours in the palette definition are close to the ones used in the logo makie. Other two, are close to the Julia Logo.

Type of change

Delete options that do not apply:

• [x ] New feature (non-breaking change which adds functionality)

Checklist

• [ ] Added an entry in NEWS.md (for new features and breaking changes)
• [ x] Added or changed relevant sections in the documentation
• [ ] Added unit tests for new algorithms, conversion methods, etc.
• [ ] Added reference image tests for new plotting functions, recipes, visual options, etc.

[lazarusA]

These are some examples added to the docs, if they work.

[jkrumbiegel]

Thank you for your work on the new theme!

After having a quick look at the docs build, here are some first suggestions, in no particular order:

• I think theme_makie might be confusing as it suggests it is the default when it's not. People would then need to ask, did you use the Makie theme or theme_makie?
• In the docs build, the scatter markers are huge

• You have changed the resolution in the theme, I think that's also confusing for a standard theme. None of the other themes change this value and it should vary a lot by use case anyway which figure size is appropriate.
• The overview plots are cool but some are kind of too huge for the website, making text look quite small etc. Also, I don't like that only this theme has extensive examples and the others don't. If you want to add docs on cycling etc, maybe on the main theming page, but the example page should have the same examples for every theme so they can be easily compared.
• Aside from the huge markers, I think it would be better if the 3d plots were less random, as that always looks less "polished" than with some more carefully chosen data like in a real plot.

[lazarusA]

• theme_makie is indeed not a good name. I'm open to suggestions. theme_makie2 ? theme_jlmke ?
• I changed the figure size and ratio, because I'm always changing that for plots that go into papers. The default one on my end is never a good starting point.
• "overview plots"... agree... I will rm them and just leave the same example used for the other themes.
• cycling. Those were a pain(the examples) to get them right. So, there should be more examples in the docs for them. So, probably I will moved somewhere else as suggested.
• marker sizes.... is the usual pain between GLMakie and CairoMakie.... with GLMakie they are ok. I didn't know how to properly verify if that was being done correctly in the docs.

thanks for your suggestions.

[ffreyer]

marker sizes.... is the usual pain between GLMakie and CairoMakie.... with GLMakie they are ok. I didn't know how to properly verify if that was being done correctly in the docs.

#1596 changed how markersizes and textsizes are handled in scatter and text plots. On master (with the default markerspace = :pixel) markersize should now be in pixel units regardless of 2d or 3d. It should also be consistent across backends. So you can just drop the markersize = 80 and you should get good results.

[lazarusA]

• Ok. I rm the fig size and left the default one.
• Changed the name to theme_jlmke.
• Also, now the theme follows the convention for themes, using just the example given there. All other examples were move to theming and cycling.

Thanks for all the suggestions, things should work now.

[SimonDanisch]

Is this ready to be merged?

[lazarusA]

I'm happy as it is. I will not do further improvements, unless there are breaking changes within Makie, after that I will update accordingly.

[lazarusA]

I removed all the extra docs in order to be uniform with the other themes. Also, the theme is now called theme_jlmke (a mix of Julia and makie colours). This one should be now ready to merge @SimonDanisch ?

[lazarusA]

bump @SimonDanisch . The examples are gone. They will live in BeautifulMakie.

[jkrumbiegel]

After thinking about it some more, what I overall still don't quite like is that this theme doesn't serve a specific "purpose" like the other themes that we have. At least for each of those I had a specific use case in mind, like dark, light, minimalist, general default, matching ggplot, etc. In principle it doesn't matter because we can put however many themes we like into Makie, who cares, on the other hand I'd like the main themes to be somewhat curated so the choice for the user is easier. I'm not sure what the "theme" of this theme is. For example, it would be easier to add the color scheme as a separate thing, if that defines the look. We don't have specific themes for all the other color schemes either. The other settings I could see in the changes seem more like personal preferences to me, which is fine, it's just not a purpose. Then we might as well call it theme_lazaro ;) And in that case I would prefer to revive a MakieThemes package of some sort, where anybody can add themes of their creation, and they don't need to be as "general" as the main ones.

[lazarusA]

doesn't serve a specific "purpose"

Fair enough. Then I would just simply say, let's just called it theme_pretty whatever that means. Everyone has his own opinion about what is pretty or not.