markdown-dungeon icon indicating copy to clipboard operation
markdown-dungeon copied to clipboard

Add more dungeons, rooms or floors

Open ming-tsai opened this issue 4 years ago • 40 comments

It'd be awesome to have a lot of the dungeons, rooms, or floors, so the game could be more fun 😜

🐞 Problem Currently, we have only a bunch of dungeons, rooms, or floors in the project

🎯 Goal Have a lot of dungeons, rooms, or floors from the diverse games.

💡 Possible solutions Add new a new dungeon, rooms, or floors.

How to make it? Check out Contribution Guidelines

📋 Steps to solve the problem

  1. Comment below about what you've started working on.
  2. Add, commit, push your changes
  3. Submit a pull request and add this in comments - Addresses #
  4. Ask for a review in the comments section of the pull request
  5. Celebrate your contribution to this project 🎉

ming-tsai avatar Jan 07 '21 12:01 ming-tsai

Hi, can I help with this issue? I would like to make a pull request.

tonyren-card avatar May 09 '21 21:05 tonyren-card

Yes @antonyren-carleton, I will wait for your pull request

ming-tsai avatar May 09 '21 22:05 ming-tsai

@ming-tsai And can you please check my discussion post regarding my inquiry #152

tonyren-card avatar May 10 '21 01:05 tonyren-card

@ming-tsai And can you please check my discussion post regarding my inquiry #152

Ok, I'll check it out

ming-tsai avatar May 10 '21 11:05 ming-tsai

Hi! I would like to add some rooms for the COVID-19 dungeon, if this is okay for you.

tonyren-card avatar May 12 '21 13:05 tonyren-card

Okis, I'm waiting for your pull request 🙂

ming-tsai avatar May 12 '21 14:05 ming-tsai

Okis, I'm waiting for your pull request 🙂

Here is my pull request #155 please review thanks :)

tonyren-card avatar May 12 '21 15:05 tonyren-card

@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.

hkumar0132 avatar Jun 21 '21 17:06 hkumar0132

@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.

Yes, this repo is as you say

ming-tsai avatar Jun 22 '21 12:06 ming-tsai

time-travel dungeon #165

hkumar0132 avatar Jun 22 '21 17:06 hkumar0132

I made a pr with some .md pages added to the time travel section of the dungeon.

haddeeann avatar Jul 03 '21 00:07 haddeeann

May I contribute?

SiliconSalvation avatar Jul 23 '21 01:07 SiliconSalvation

May I contribute?

Yes @kazuma2448

ming-tsai avatar Jul 23 '21 12:07 ming-tsai

I would like to work on Time-Travel year 1800, because it's looking sooo poor :D I already prepared some rooms and floors, they are waiting to commit.

#175

Karguel1995 avatar Jul 23 '21 16:07 Karguel1995

Very creative @Karguel1995

hkumar0132 avatar Jul 23 '21 17:07 hkumar0132

I worked on improving grammar on floor 6 in English normal dungeon, files 1-4. I think the result is more enjoyable for English readers.

#178

SiliconSalvation avatar Jul 26 '21 13:07 SiliconSalvation

I would like to add more rooms/floors in the future, but for now I added a short sub-story to English>normal-dungeon!

#193

gonuma avatar Sep 24 '21 01:09 gonuma

Hi @ming-tsai, I found sci-fi-dungeon incomplete and would like to create/extend it to more rooms/floors. so can i work on this issue ? Thank you, waiting for your response.

Manas-Tiwari avatar Oct 01 '21 13:10 Manas-Tiwari

Hi @ming-tsai, I found sci-fi-dungeon incomplete and would like to create/extend it to more rooms/floors. so can i work on this issue ? Thank you, waiting for your response.

Yes, I will wait for your pull request.

ming-tsai avatar Oct 01 '21 13:10 ming-tsai

@ming-tsai sorry to ping you but can you please review my pr #198. Tysm.

Manas-Tiwari avatar Oct 01 '21 17:10 Manas-Tiwari

I already did the room. Now I don't have any idea how to make the PR properly. What happened if the original repo is updated in comparison to mine master_branch? 🍡

crisjumbo avatar Oct 14 '21 20:10 crisjumbo

@srcristofher do you mean what happens if the original repo updates, but your fork is outdated?

NS007-dev avatar Oct 14 '21 20:10 NS007-dev

Exactly. I meant that :)

crisjumbo avatar Oct 14 '21 20:10 crisjumbo

@srcristofher so when the main repo updates, and your forked repo is outdated, all you need to do is go to git bash and give the following commands: if you are not already in the repo environment: cd markdown-dungeon To get upstream/update your fork, you git pull to pull all the new changes from the original repo, to your forked one. git pull

How to do it online:

At the top, you will see this: image

just press fetch upstream, and the green button.

Need any more help, feel free to ask.

NS007-dev avatar Oct 14 '21 20:10 NS007-dev

hi , please assign me i want to work

mohitahlawat2001 avatar Oct 18 '21 15:10 mohitahlawat2001

hi , please assign me i want to work

Hi @mohitahlawat2001, This issue is not assignable, you just open a pull request and mention it on this issue

ming-tsai avatar Oct 18 '21 16:10 ming-tsai

Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.

catherinepham avatar Jan 28 '22 17:01 catherinepham

Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.

~~Have you forked the repo first @catherinepham ?~~ Sorry I just saw the pr. Thank you.

NS007-dev avatar Jan 28 '22 19:01 NS007-dev

Thank you for responding! Are you able to review the pr for me?

catherinepham avatar Jan 28 '22 20:01 catherinepham

Thank you for responding! Are you able to review the pr for me?

Hi @catherinepham, Your pull request @ hkumar0132 will be review it

ming-tsai avatar Feb 02 '22 05:02 ming-tsai