makemd icon indicating copy to clipboard operation
makemd copied to clipboard

Incompatibility with QuickAdd

Open MarcosDantasdeSantana opened this issue 2 years ago • 3 comments

When you have a command to create a note with QuickAdd, and this option is active: IN THE SAME FOLDER OF THE ACTIVE FILE. When you use the command when the active file is the FOLDER NOTE of Make.md surges an error of QuickAdd: NO ACTIVE FILE.

MarcosDantasdeSantana avatar Feb 21 '23 16:02 MarcosDantasdeSantana

Thanks, there's no immediate solution but this will be investigated soon. This will be resolved with many other bugs caused by the flow editor not being recognized as the active file by obsidian.

jp-cen avatar Feb 22 '23 01:02 jp-cen

Hi @jp-cen

I was looking at Make.md while checking the issue on my end. It looks great. Seriously good work!

From my testing, and I apologize if I'm getting the terminology wrong, neither the folder note nor flow editor are registered as the active file when active.

Perhaps you could monkey-patch getActiveFile, and then it would semi-work, depending on what other features the plugins then expect (e.g. editor information, current cursor position, etc.). But that would be very prone to bugs for everyone, and a headache to debug, so need to be careful. And it might introduce additional overhead, affecting performance.

chhoumann avatar Feb 22 '23 05:02 chhoumann

Just want to mention that this has the same incompatibility with Quick Explorer. I suspect the issue is not using a FileView as the base type for SpaceViewContainer? You need to have a FileView subclass for getActiveFile() to work, I believe.

The changes are probably not that extensive: inherit from FileView, add a .file property (which can be a getter), and have getState and setState not call super (so as to avoid adding a file prop to the state or triggering the other FileView methods). And I guess making sure nothing else breaks that was working before. :wink:

pjeby avatar Apr 29 '25 02:04 pjeby