Inline Context stopped working some time ago, no HTML inline context components injected

Open replete opened this issue 1 year ago • 1 comments

Problem

Thanks for making a great plugin, although I am just using it for the banners functionality. Or at least I was until it stopped working late last year.

If I delete the plugin and reinstall, it works on first boot, but then stops working after restarting Obsidian. By not working I mean that no HTML components are loaded into the editor, hence no banners. But Flow still works, so I'm guessing this is some settings bug related to a perhaps uncommon use-case of a user only have a minimal set of settings enabled?

Screenshot 2024-03-27 at 11 55 20 There should be some HTML appearing in the DOM such as <div class="mk-inline-context">..., but it does not appear to inject the component anymore...

I can create a new note with frontmatter such as:

---
banner:   Assets/Banners/image.jpg
---

Nothing happens...

Environment

Obsidian: v1.5.11 (installer 1.5.11) MacOS: 13.6.5 Make.MD: 0.95

Make.MD Settings

Screenshot 2024-03-27 at 12 18 14

data.json:

{
  "newNotePlaceholder": "Untitled", 
  "defaultInitialization": false, 
  "filePreviewOnHover": false, 
  "flowMenuEnabled": true, 
  "markSans": false, 
  "blinkEnabled": false, 
  "makeMenuPlaceholder": false, 
  "mobileMakeBar": true, 
  "inlineStyler": true, 
  "makerMode": true, 
  "imageThumbnails": false, 
  "spacesMDBInHidden": true, 
  "inlineStylerColors": false, 
  "editorFlow": true, 
  "internalLinkClickFlow": true, 
  "contextEnabled": false, 
  "spaceViewEnabled": false, 
  "saveAllContextToFrontmatter": false, 
  "editorFlowStyle": "seamless", 
  "autoOpenFileContext": false, 
  "activeView": "Spaces/Home", 
  "hideFrontmatter": true, 
  "activeSpace": "", 
  "defaultDateFormat": "MMM dd yyyy", 
  "spacesEnabled": false, 
  "spacesPerformance": false, 
  "enableFolderNote": true, 
  "folderIndentationLines": true, 
  "revealActiveFile": false, 
  "spacesStickers": false, 
  "spaceRowHeight": 29, 
  "spacesDisablePatch": false, 
  "folderNoteInsideFolder": true, 
  "sidebarTabs": true, 
  "showRibbon": true, 
  "deleteFileOption": "trash", 
  "expandedSpaces": [
    "/"
  ], 
  "expandFolderOnClick": true, 
  "menuTriggerChar": "/", 
  "inlineStickerMenu": false, 
  "emojiTriggerChar": ":", 
  "folderContextFile": "context", 
  "folderFrameFile": "frames", 
  "spacesFolder": "Spaces", 
  "hiddenFiles": [], 
  "hiddenExtensions": [
    ".mdb"
  ], 
  "inlineBacklinks": false, 
  "inlineContext": true, 
  "inlineBacklinksExpanded": false, 
  "inlineContextExpanded": true, 
  "inlineContextSectionsExpanded": true, 
  "dataviewInlineContext": false, 
  "inlineContextNameLayout": "vertical", 
  "waypoints": [
    "Spaces/Home", 
    "/", 
    "spaces://$tags"
  ], 
  "spacesUseAlias": false, 
  "fmKeyAlias": "aliases", 
  "fmKeyBanner": "banner", 
  "fmKeyColor": "color", 
  "fmKeySticker": "sticker", 
  "fmKeyContexts": "_contexts", 
  "fmKeySort": "_sort", 
  "fmKeyFilter": "_filters", 
  "fmKeyLinks": "_links", 
  "openSpacesOnLaunch": true, 
  "indexSVG": false, 
  "quickFrames": [], 
  "readableLineWidth": true, 
  "autoAddContextsToSubtags": true, 
  "autoMigration08": false, 
  "releaseNotesPrompt": 0.9, 
  "enableDefaultSpaces": false, 
  "enableTagSpaces": true, 
  "enableHomeSpace": true, 
  "showSpacePinIcon": true, 
  "minimalFix": true, 
  "experimental": false, 
  "systemName": "Vault"
}

Installed plugins:

// [...new Set(app.plugins.enabledPlugins)] (34) 
['obsidian-advanced-uri', 'auto-class', 'calendar', 'cmdr', 'obsidian-hide-sidebars-when-narrow', 'hotkeysplus-obsidian', 'obsidian-icon-folder', 'obsidian-excalidraw-plugin', 'cm-editor-syntax-highlight-obsidian', 'obsidian-minimal-settings', 'obsidian-meta-bind-plugin', 'open-vscode', 'periodic-notes', 'quickadd', 'obsidian-task-progress-bar', 'templater-obsidian', 'obsidian-toggle-list', 'mysnippets-plugin', 'no-dupe-leaves', 'file-explorer-note-count', 'easy-toggle-sidebars', 'settings-search', 'modalforms', 'obsidian-daily-note-outline', 'custom-sort', 'obsidian-shortcut-launcher', 'obsidian-contextual-typography', 'open-in-new-tab', 'obsidian-tracker', 'omnisearch', 'snippet-commands-obsidian', 'dataview', 'obsidian-custom-frames', 'make-md']

Mar 27 '24 12:03 replete

Thanks for reporting this. Will take a look shortly

Get Outlook for iOShttps://aka.ms/o0ukef

From: Phil Ricketts @.> Sent: Wednesday, March 27, 2024 8:21:39 AM To: Make-md/makemd @.> Cc: Subscribed @.***> Subject: [Make-md/makemd] Inline Context stopped working some time ago, no HTML inline context components injected (Issue #297)

Problem

Thanks for making a great plugin, although I am just using it for the banners functionality. Or at least I was until it stopped working late last year.

Screenshot.2024-03-27.at.11.55.20.png (view on web)https://github.com/Make-md/makemd/assets/812139/393bdc33-be16-474f-a56f-37a451f01e2e There should be some HTML appearing in the DOM such as

..., but it does not appear to inject the component anymore...

I can create a new note with frontmatter such as:

banner: Assets/Banners/image.jpg

Nothing happens...

Environment

Obsidian: v1.5.11 (installer 1.5.11) MacOS: 13.6.5 Make.MD: 0.95

Make.MD Settings

Screenshot.2024-03-27.at.12.18.14.png (view on web)https://github.com/Make-md/makemd/assets/812139/54735fcd-eadb-4ae7-acc5-24992724edc3 Screenshot.2024-03-27.at.12.18.24.png (view on web)https://github.com/Make-md/makemd/assets/812139/6e397117-0f1b-4bf3-a57e-66462c1febb6 Screenshot.2024-03-27.at.12.18.46.png (view on web)https://github.com/Make-md/makemd/assets/812139/2f9376c1-4f53-4a7c-8054-87870b79f2ea

data.json:

{ "newNotePlaceholder": "Untitled", "defaultInitialization": false, "filePreviewOnHover": false, "flowMenuEnabled": true, "markSans": false, "blinkEnabled": false, "makeMenuPlaceholder": false, "mobileMakeBar": true, "inlineStyler": true, "makerMode": true, "imageThumbnails": false, "spacesMDBInHidden": true, "inlineStylerColors": false, "editorFlow": true, "internalLinkClickFlow": true, "contextEnabled": false, "spaceViewEnabled": false, "saveAllContextToFrontmatter": false, "editorFlowStyle": "seamless", "autoOpenFileContext": false, "activeView": "Spaces/Home", "hideFrontmatter": true, "activeSpace": "", "defaultDateFormat": "MMM dd yyyy", "spacesEnabled": false, "spacesPerformance": false, "enableFolderNote": true, "folderIndentationLines": true, "revealActiveFile": false, "spacesStickers": false, "spaceRowHeight": 29, "spacesDisablePatch": false, "folderNoteInsideFolder": true, "sidebarTabs": true, "showRibbon": true, "deleteFileOption": "trash", "expandedSpaces": [ "/" ], "expandFolderOnClick": true, "menuTriggerChar": "/", "inlineStickerMenu": false, "emojiTriggerChar": ":", "folderContextFile": "context", "folderFrameFile": "frames", "spacesFolder": "Spaces", "hiddenFiles": [], "hiddenExtensions": [ ".mdb" ], "inlineBacklinks": false, "inlineContext": true, "inlineBacklinksExpanded": false, "inlineContextExpanded": true, "inlineContextSectionsExpanded": true, "dataviewInlineContext": false, "inlineContextNameLayout": "vertical", "waypoints": [ "Spaces/Home", "/", "spaces://$tags" ], "spacesUseAlias": false, "fmKeyAlias": "aliases", "fmKeyBanner": "banner", "fmKeyColor": "color", "fmKeySticker": "sticker", "fmKeyContexts": "_contexts", "fmKeySort": "_sort", "fmKeyFilter": "_filters", "fmKeyLinks": "_links", "openSpacesOnLaunch": true, "indexSVG": false, "quickFrames": [], "readableLineWidth": true, "autoAddContextsToSubtags": true, "autoMigration08": false, "releaseNotesPrompt": 0.9, "enableDefaultSpaces": false, "enableTagSpaces": true, "enableHomeSpace": true, "showSpacePinIcon": true, "minimalFix": true, "experimental": false, "systemName": "Vault" }

Installed plugins:

// [...new Set(app.plugins.enabledPlugins)] (34) ['obsidian-advanced-uri', 'auto-class', 'calendar', 'cmdr', 'obsidian-hide-sidebars-when-narrow', 'hotkeysplus-obsidian', 'obsidian-icon-folder', 'obsidian-excalidraw-plugin', 'cm-editor-syntax-highlight-obsidian', 'obsidian-minimal-settings', 'obsidian-meta-bind-plugin', 'open-vscode', 'periodic-notes', 'quickadd', 'obsidian-task-progress-bar', 'templater-obsidian', 'obsidian-toggle-list', 'mysnippets-plugin', 'no-dupe-leaves', 'file-explorer-note-count', 'easy-toggle-sidebars', 'settings-search', 'modalforms', 'obsidian-daily-note-outline', 'custom-sort', 'obsidian-shortcut-launcher', 'obsidian-contextual-typography', 'open-in-new-tab', 'obsidian-tracker', 'omnisearch', 'snippet-commands-obsidian', 'dataview', 'obsidian-custom-frames', 'make-md']

— Reply to this email directly, view it on GitHubhttps://github.com/Make-md/makemd/issues/297, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFHKNSVVGDFN642G6XCUETY2K2VHAVCNFSM6AAAAABFKYNGL2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTANRVHAYTIMQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Mar 27 '24 17:03 jp-cen