makemd icon indicating copy to clipboard operation
makemd copied to clipboard

Flow doesn't do anything

Open huachuman opened this issue 2 years ago • 9 comments

I enabled the flow editor but all it does is put two little buttons at the top right of the block. Even if I click flow editor, nothing happens. It just stays a regular block embed. I click anywhere on the block and it just does the default behavior, which is selecting the ![[title]] of the embed. I've tried restarting Obsidian to no effect.

huachuman avatar Nov 09 '23 09:11 huachuman

Yes, I am also having problems with the flow editor, it even deletes characters from the title when I click the button.

javinavasviolin avatar Nov 10 '23 12:11 javinavasviolin

I thought that make.md would get better with development but it seems to be going backwards.

Probably the most overhyped plugin in the history of plugins, given how many people have made youtube videos about this plugin who clearly haven't tried it for more than a few days.

huachuman avatar Nov 10 '23 16:11 huachuman

Thanks for reporting this. It seems like Obsidian's markdown renderer was updated and caused the position calculation to be incorrect. This has been fixed in the new patch, although there is still one case where this still happens and I'll look into it for the next patch.

jp-cen avatar Nov 10 '23 23:11 jp-cen

Thank you so much. When I click on "toggle flow" I never get the same results. Usually it doesn't allow me to edit the block and deletes characters previously. In the video you can see that when I click on "toggle flow" it deletes characters on the heading.

https://github.com/Make-md/makemd/assets/145867557/77dca4df-7fc4-4457-b7ee-e88e5cf17183

javinavasviolin avatar Nov 10 '23 23:11 javinavasviolin

This is post patch? This is the issue I’m looking into, it seems like obsidian no longer deterministically returns the position of the current embed. You can always add the ! In front of the embed block. I’m looking for a new strategy to patch this

Get Outlook for iOShttps://aka.ms/o0ukef


From: javinavasviolin @.> Sent: Friday, November 10, 2023 6:45:50 PM To: Make-md/makemd @.> Cc: JPC @.>; Comment @.> Subject: Re: [Make-md/makemd] Flow doesn't do anything (Issue #210)

Thank you so much. When I click on "toggle flow" I never get the same results. Usually it doesn't allow me to edit the block and deletes characters previously. In the video you can see that when I click on "toggle flow" it deletes characters on the heading.

https://github.com/Make-md/makemd/assets/145867557/77dca4df-7fc4-4457-b7ee-e88e5cf17183

— Reply to this email directly, view it on GitHubhttps://github.com/Make-md/makemd/issues/210#issuecomment-1806568250, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFHKNTQLN4WWWNKTXGZFDTYD24C5AVCNFSM6AAAAAA7EITP5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGU3DQMRVGA. You are receiving this because you commented.Message ID: @.***>

jp-cen avatar Nov 11 '23 00:11 jp-cen

@javinavasviolin the version you're using seems to be before the patch, let me know if you get a chance to update and test the fix

jp-cen avatar Nov 11 '23 01:11 jp-cen

Hi @jp-cen , I just updated and it still is behaving weird, now it adds "!" each time that I click it and doesn't allow me to edit the block inside.

https://github.com/Make-md/makemd/assets/145867557/6391e62f-efc0-47a3-ae72-4aa690e2b683

javinavasviolin avatar Nov 11 '23 07:11 javinavasviolin

The ! should be inserted infront of the embed block but the underlying editor now returns two possible positions instead of reliably returning one. I’ll be rewriting the block position calculation today to address this. The most reliable way to create an editable block is to use the slash menu and directly create one from scratch.

jp-cen avatar Nov 11 '23 12:11 jp-cen

I tried from slash, now doesn't appear the option of "flow note" only "lexisting note" that I guess is the same.

-Now the first time that I create it allows me to edit, but when I click again it I cannot and as you can see the "!" changes the color and becomes dark.

  • When I delete the "!" it allows to edit again.
  • When I delete the linked note you can see a bunch of "!" that weren't there before as if they would be kind of residual.

I am not a programmer but I love Make.md since the first moment I saw it and I believe in your project, you are amazing guys!

https://github.com/Make-md/makemd/assets/145867557/1797a90d-5e8d-4673-8761-9be5cba3d63d

javinavasviolin avatar Nov 11 '23 13:11 javinavasviolin

Flow editor, make menu and inline styler are now available as a standalone plug-in at https://github.com/Make-md/Obsidian-Basics

This will allow easier contribution, debugging and improvements to these features and also overall stability of the main make.md plug-in.

It is available now as a beta and will be submitted to Obsidian community plug-ins shortly. Feel free to provide any feedback or suggestions in the new repo.

jp-cen avatar Jan 04 '25 04:01 jp-cen