Jongsun Suh comments

Results 100 comments of


                                            Jongsun Suh

Upgrade to TypeScript v5.1

For the trial run, branch from this PR where the v5.0 upgrade is in place: https://github.com/MetaMask/core/pull/3645. If the PR is merged, use the latest version of core.

chore: Upgrade core packages to release 159.0.0

Migrating `json-rpc-engine` to `@metamask/json-rpc-engine` has been previously attempted, - https://github.com/MetaMask/metamask-extension/pull/22875 - https://github.com/MetaMask/metamask-extension/pull/23532 but postponed due to the possibility of breaking dapps: - https://consensys.slack.com/archives/GN3SR3GNM/p1710780668884679 - https://consensys.slack.com/archives/C01V1L10W2E/p1719347208154459 Has this issue been resolved?...

Convert AssetsContractController from BaseControllerV1 to BaseControllerV2

- Define internal messenger actions/events types. - Define messenger actions for all public methods of `AssetsContractController` class. - Define `AssetsContractControllerActions`, `AssetsContractControllerEvents`, `AssetsContractControllerGetStateAction` (using `ControllerGetStateAction` type), `AssetsContractControllerStateChangeEvent` (using `ControllerStateChangeEvent` type) -...

cherry-pick(v12.1.1): Bump `@metamask/eth-json-rpc-middleware` to `^14.0.0` (#26143)

@metamaskbot update-policies

cherry-pick(v12.1.1): Bump `@metamask/eth-json-rpc-middleware` to `^14.0.0` (#26143)

@SocketSecurity ignore npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] npm/@storybook/[email protected] Patch updates auto-applied due to caret specifier...