HexNicks icon indicating copy to clipboard operation
HexNicks copied to clipboard

Allow `/nickcolor #facade` as `/nickcolor <#facade>`

Open funnyboy-roks opened this issue 10 months ago • 2 comments

Is your feature request related to a problem? Please describe. Soooo many people are confused about /nickcolor needing the angle brackets (<>) for the command

Describe the solution you'd like Interpret #rrggbb as <#rrggbb> and red as <red>

Describe alternatives you've considered The only other way that could benefit users would be to give a more helpful error message that is not just "You may only includes color codes."

Potential Implementation Check if the argument has <> and add them if it doesn't before it's parsed, this would be a bit of a dirty implementation, but it would work well, and shouldn't break anything else.

Basically, we take this

https://github.com/MajekDev/HexNicks/blob/2afbedc673b8ff28500a2953ac35745d5db5bbc3/src/main/java/dev/majek/hexnicks/command/CommandNickColor.java#L58-L60

and add

if (!nickInput.startsWith("<") && !nickInput.endsWith(">")) {
    nickInput = '<' + nickInput + '>';
}

If there is a concern about that failing, then we could put the "corrected" version in a new variable and use the old one if the colour code is detected to be wrong.

I'd be happy to open a PR with these changes, if feature is desired.

funnyboy-roks avatar Aug 28 '23 03:08 funnyboy-roks