helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Only set the externalTrafficPolicy when spec.type is not ClusterIP

Open WebSpider opened this issue 1 year ago • 3 comments

Setting the externalTrafficPolicy to anything non-default is not supported on ClusterIP as per https://github.com/kubernetes/kubernetes/issues/67202

Fixes #266

WebSpider avatar Oct 18 '24 07:10 WebSpider

Trivy seems to be setup incorrectly

WebSpider avatar Oct 23 '24 02:10 WebSpider

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 22 '24 02:11 github-actions[bot]

When can we expect this to be merged? I was just about to submit the same patch 😂

aki-ks avatar Mar 15 '25 22:03 aki-ks

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 29 '25 02:09 github-actions[bot]

/unstale

WebSpider avatar Sep 29 '25 05:09 WebSpider

@WebSpider can you please rebase?

DrPsychick avatar Oct 17 '25 16:10 DrPsychick

@DrPsychick rebased, but tests still fail when setting up dependencies. Looks like a bitnami thing..

WebSpider avatar Oct 20 '25 07:10 WebSpider

The Docker registry is currently broken. See https://www.dockerstatus.com/

promasu avatar Oct 20 '25 07:10 promasu

The registry works again so we might retry to run the CI if it's happy now :D

promasu avatar Oct 20 '25 11:10 promasu

The registry works again so we might retry to run the CI if it's happy now :D

Yes, unfortunately, I do not have sufficient permissions to kick CI, and pushing 2 commits to do/undo a space is a bit .. primitive.

WebSpider avatar Oct 20 '25 12:10 WebSpider

Me neither, you could amend your commit and force-push to create a new commit hash, but Docker Hub seems to be broken again, so I think we don't stress it and wait until everything is really stable again

promasu avatar Oct 20 '25 13:10 promasu