Mailu
allow defining ipFamilyPolicy for external service
For dual stack (IPv4 and IPv6) clusters, services need to be explicitly opted-in into having two addresses. This is done through the ipFamilyPolicy field, as documented in https://kubernetes.io/docs/concepts/services-networking/dual-stack/#services.
I've wired the templates in a way where if this field is not present, nothing is rendered. This preserves the usual behavior of not specifying this value altogether for services.
CI/CD fails for reasons unknown to me, but I think the PR itself should be okay.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
Hey folks, this has been lingering for a long while now. Is there anything I can do to help get this merged? Due to the nature of helm charts, this not being upstream makes me maintain and deploy a fork of the chart with this commit on it, which is not great. Thanks!
Hi @roobre I'm in contact with the maintainer to see how we can spped things up here.
@fastlorenzo Sorry for the direct ping, but you seem to be the most recent contributor here. Is there any chance you can stamp this? Should be a simple change 🙏🏻
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
I know it's been quite a while, but we're now slowly getting up to speed with timely reviews again. @nadiamoe would you mind to rebase the PR? It's already approved and I'll merge it right away.