helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

feat(proxy): add PROXY_PROTOCOL parameter

Open Sh4kE opened this issue 2 years ago • 6 comments

Adds the possibility to define proxy protocol parameter

Sh4kE avatar Sep 16 '23 09:09 Sh4kE

I see that we've missed it in our docs, but "all-but-http" is now valid too on master

nextgens avatar Sep 16 '23 09:09 nextgens

Ahh the haven't updated their docs yet. I missed that.

Sh4kE avatar Sep 16 '23 09:09 Sh4kE

Hmm are you sure about that? This is the PR which introduced the parameter and I can't seem to find that value: https://github.com/Mailu/Mailu/pull/2717/files#diff-68a31565c7f34fbe6ac80bbc0b4287ee3711fa615ce5b973c1f83f285d0d28fa

Sh4kE avatar Sep 16 '23 09:09 Sh4kE

https://github.com/Mailu/Mailu/pull/2903/files

But that's only valid for master... and arguably the chart doesn't target that

nextgens avatar Sep 16 '23 09:09 nextgens

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 17 '23 02:10 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 24 '23 02:11 github-actions[bot]

Fixed in #354 , thanks for the PR though

fastlorenzo avatar Jun 28 '24 21:06 fastlorenzo