Mailu icon indicating copy to clipboard operation
Mailu copied to clipboard

Add Belarusian translation.

Open spoooyders opened this issue 11 months ago • 12 comments

What type of PR?

Translation.

What does this PR do?

Adds Belarusian translation.

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list.

  • [x] In case of feature or enhancement: documentation updated accordingly
  • [x] Unless it's docs or a minor change: add changelog entry file.

spoooyders avatar Mar 26 '24 07:03 spoooyders

Thanks for submitting this pull request. Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

mergify[bot] avatar Mar 26 '24 07:03 mergify[bot]

try

Build succeeded:

bors-mailu[bot] avatar Mar 26 '24 08:03 bors-mailu[bot]

Ok, now I think it is finally ready and correct. Please review.

ghost avatar Mar 26 '24 08:03 ghost

bors try

Diman0 avatar Mar 26 '24 12:03 Diman0

try

Build succeeded:

bors-mailu[bot] avatar Mar 26 '24 12:03 bors-mailu[bot]

Both untranslated text strings are new in the upcoming release and have not been translated yet in any of the other languages. That is why you missed these.

Diman0 avatar Mar 27 '24 08:03 Diman0

On the user edit page (https://example.com/admin/user/edit/[email protected]) you are also missing the translations for:

  • Force password change at next login
  • Allow the user to spoof the sender (send email as anyone)

You can translate the earlier mentioned missing translations via:

#: mailu/ui/templates/domain/details.html:19
msgid "Download zonefile"
msgstr "translation of Download zonefile"

#: mailu/ui/forms.py:134
msgid "Current password"
msgstr "translation of Current password"

#: mailu/ui/forms.py:102
msgid "Force password change at next login"
msgstr "translation of Allow the user to spoof the sender (send email as anyone)"

#: mailu/ui/forms.py:98
msgid "Allow the user to spoof the sender (send email as anyone)"
msgstr "translation of Allow the user to spoof the sender (send email as anyone)"

Diman0 avatar Mar 27 '24 09:03 Diman0

Ok, tried to add them. Also added translation for a note about Apple autoconfig.

Not sure how to get an image to test it all - do I need to post bors try for it to build? Or does only maintainers have permissions to build?...

Anyways, @Diman0 please take another look.

ghost avatar Mar 30 '24 10:03 ghost

You are correct. Only maintainers can trigger a build. You can test the new build using tag pr-3207 Ghcr.io/Mailu/admin:pr3207

Bors try

Diman0 avatar Mar 30 '24 11:03 Diman0

try

Build succeeded:

bors-mailu[bot] avatar Mar 30 '24 11:03 bors-mailu[bot]

@Diman0 I verified it, everything looks good.

ghost avatar Mar 30 '24 17:03 ghost

@Diman0 I verified it, everything looks good.

Thank you for the confirmation. It also looks good to me. At least that the interface is translated to a different language than English. I don't speak Belarusian so I trust the translation is correct.

Diman0 avatar Apr 02 '24 07:04 Diman0

bors r+

mergify[bot] avatar Jun 09 '24 09:06 mergify[bot]

Build succeeded:

bors-mailu[bot] avatar Jun 09 '24 10:06 bors-mailu[bot]