mailtrain icon indicating copy to clipboard operation
mailtrain copied to clipboard

Published 20 hours ago • verified publisher icon Mailtrain-org

decode possible encoded chunks in header

Open j-mir-prazak opened this issue 2 years ago • 1 comments

dkimKey expects JSON, however serveral times now, mailtrain started giving dkim header as encoded chunks. there is no try and catch on the json parse, so the emails won't be sent.

require('libmime').decodeWords( header ) decodes chunks if present, or leaves the string alone - so even if the json is passed, it should not change the string.

i could not find the reason for the encoding so far

j-mir-prazak avatar Sep 03 '22 11:09 j-mir-prazak

Thanks. I've never encountered this problem. At least I'm not aware of it. Could we have one more person to test this PR on their installation before I merge it? Just to be sure this does not break anything.

bures avatar Sep 03 '22 11:09 bures

Thanks. I've never encountered this problem. At least I'm not aware of it. Could we have one more person to test this PR on their installation before I merge it? Just to be sure this does not break anything.

@bures This change solves the problem #1142

iafilin avatar Dec 11 '22 02:12 iafilin

Perfect. Thank you both.

bures avatar Dec 11 '22 06:12 bures