mailtrain icon indicating copy to clipboard operation
mailtrain copied to clipboard

Published 20 hours ago • verified publisher icon Mailtrain-org

Fix issue #598

Open D4rk4 opened this issue 3 years ago • 6 comments

@talheim-it this one fix issue with non-Latin chars

D4rk4 avatar May 06 '22 12:05 D4rk4

@D4rk4 thanks I forward it to @bures

forge0ne avatar May 10 '22 14:05 forge0ne

I analyze the use of HE. I believe it is there to allow you to include text custom fields that contain characters that would be otherwise interpreted as HTML. For instance "<". So, to sum up, I think just removing the HE is not easily an option as then it means that you subscription fields have to be HTML-safe.

Just to be sure, I'm right, could you try in your modified Mailtrain instance the following FIRST_NAME: A <B> C ? Thanks.

bures avatar May 11 '22 09:05 bures

image @bures

D4rk4 avatar May 11 '22 11:05 D4rk4

And what happens when you deliver an email to this person and use the FIRST_NAME merge tag in the campaign content?

bures avatar May 11 '22 12:05 bures

image @bures in the message it's parsed as regular HTML tags. In the MT admin panel it's parsed as text.

D4rk4 avatar May 11 '22 12:05 D4rk4

Yes. This is what I thought. With the "simple" tag language, the tags should be interpreted as plain text. That's why the entity encoding is present. I believe, it would be better to to change the settings of HE (or use some other encoder), so that for instance <, >, & gets encoded, while the characters with various diacritics are not. Could you please give it a try? I would be happy to accept such PR. Thanks.

bures avatar May 11 '22 13:05 bures