jest-tap-reporter
jest-tap-reporter copied to clipboard
MailOnline
[commit-name] Commit names do not satisfy requirements
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/d7dac6d82b6ecbea6c5b715e7c0d89524e8d940f chore: remove key-value prefix, rename pending -> skipped and color yellow
Bad commit name by @greenkeeper[bot]: https://github.com/MailOnline/jest-tap-reporter/commit/a6ad77c47efc4e1548cf33e4db594ac1b4bb7196 docs(readme): add Greenkeeper badge
Bad commit name by @greenkeeper[bot]: https://github.com/MailOnline/jest-tap-reporter/commit/0e6dd94431af3a25a301a63c8e0ee2b01271ada2 chore(package): update dependencies
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/20018d5838a8516464a6af1365ba8f266d7df39e feat: hide long stack traces by default, add option showInternalStackTraces to enable them
@claudiorodriguez @streamich The rule commit-name implements, quite pedantically :), your guidelines as configured here: https://github.com/MailOnline/gh-lint-config/blob/master/config.yaml#L36
In this case it fails because the first line of your commit should be under 64 characters (and actually your guidelines say 50).
I am not that precious about this rule, I care much more about PRs being approved, no commits without PRs, JIRA ticket numbers used in PRs (the latter two are coming soon). So I don't mind disabling it - feel free to update that config. But then, maybe it's worth updating the guidelines as well?
Closing the issue won't help - it'll get reopened tomorrow again and will be closed when there are no new offending commits in 30 days...
Scope is not allowed by default, I added, so it won't alert on GK commits any more...
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/f2e5d812028ed009dd8f86172e7ff720ca7344fc docs: inline Greenkeeper badge
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/362e81ddcbf5fe1b4586cec53adc26d9967ee0de test: add tests for LoggerTemporal
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/ff9d3072efef49cab88b1221651d4d05dfe3a3a7 test: add tests for LoggerBufferable
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/776260b49f82c8f0f70ca4690e58bb17e4a1e197 docs: add screenshots, refactor reme
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/073924d30c699086f4310491a16134d7452fc10b chore: move tests to tests folders
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/3169db2d4e6d6ae5039cb8fd5e0049ba09a97b98 feat: show progress while running tests
Bad commit name by @claudiorodriguez: https://github.com/MailOnline/jest-tap-reporter/commit/cbf54bd63a0a2117b31970b5686aca278e15dcdc chore: fix linting
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/6cbddcd730b8d6ee8a7519bb8e3274e24c477fb1 fix: fixtures
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/c8d33a7f7bb446a0af1baf3dc4974c56c7a98b27 feat: improve at-path stack trace formatting
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/d921d73ac5ed1ed96ffcaf61f9f328e95b31fa50 feat: display error in test suite itself
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/3f81383dc71a27f909d967b3ed11a0ba8f544e7c fix: recognize more generic 'Expected' headers
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/f904515173ed191c54a0ac7a5e684b8155d54f03 refactor: create /format folder
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/1511ac307849715cc32e8c8d48e472b730472d58 fix: dont print codeFrame if empty
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/b44dccd7e59fdab1b2f9e699dd6fb3de3213e2e0 fix: dont print codeFrame if empty
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/0994dba679fa1fdef536b66647d8d0b2afca1a77 feat: highlight error code in terminal
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/a6f2ce70ee12319af24d8a23341091c69de42bf1 test: update snapshot
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/e3584ea61a78b1e001375964f2fcfb14a9b9da02 refactor: for readability
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/6284affa79fc26b64e98dbe20934041b6e2ef3aa test: fix tests
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/886b24b1a22a82d834dbc5ea75eedb4e864266f1 feat: improve error reporting
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/bb29ab256c8e2e5b114fd4df43ebc25d31e99ec5 feat: add progress bars to summary
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/d225a8d2e8a112fcd46cdcdc8366f5eadfc033b7 feat: add progress bar
Bad commit name by @streamich: https://github.com/MailOnline/jest-tap-reporter/commit/38c752b026b3ea24f7dd838687da07f0f2704f6c docs: license