Feat/shadcn themes
Description
This pull request introduces a custom theming system, fulfilling the requirements outlined in /claim #883.
Users can now create, customize, manage, and apply detailed themes to personalize their mail client experience via the /settings/themes page. Themes are persisted to the database and can be applied to the active connection. When a connection is active, its associated theme (if any) is loaded automatically.
Key features include:
- Database schema and server actions for theme CRUD operations, user/connection association, and public sharing status.
- A theme editor with live preview for customizing colors, fonts, spacing, shadows, corner radius, and backgrounds (color, gradient, image).
- A management UI to view, create, edit, delete, and apply themes.
- A
CustomThemeProviderto dynamically load themes and inject CSS variables. - Several preset themes (Light, Dark, Sunset Horizon, Cyberpunk, Amber Minimal, Amethyst Haze, Bold Tech, Bubblegum, Caffeine) with light/dark variants, addable via a button in settings.
- Fixes for previous issues where UI elements (main layout, sidebar, compose button/dialog, mail panels) did not respect theme changes.
- Resolution of client-side build errors related to server-only code imports.
Type of Change
Please delete options that are not relevant.
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
- [x] ✨ New feature (non-breaking change which adds functionality)
- [ ] 💥 Breaking change (fix or feature with breaking changes)
- [ ] 📝 Documentation update
- [x] 🎨 UI/UX improvement
- [ ] 🔒 Security enhancement
- [ ] ⚡ Performance improvement
Areas Affected
Please check all that apply:
- [ ] Email Integration (Gmail, IMAP, etc.)
- [x] User Interface/Experience
- [x] Authentication/Authorization (Server actions check session)
- [x] Data Storage/Management (New
themetable,ThemeSettingstype) - [x] API Endpoints (Via Next.js Server Actions)
- [ ] Documentation
- [ ] Testing Infrastructure
- [ ] Development Workflow
- [ ] Deployment/Infrastructure
Testing Done
Describe the tests you've done:
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [x] Manual testing performed:
- Verified theme creation, editing (with live preview), and deletion in
/settings/themes.
- Tested applying various themes (presets, custom, light/dark) and confirmed immediate UI updates for sidebar, main mail layout, mail list/view panels, compose button/dialog.
- Confirmed "Add Preset Themes" button adds missing themes correctly.
- Tested theme persistence across page reloads/sessions.
- Verified "Reset to Default" functionality.
- Confirmed build errors related to
tlsare resolved.
- Verified theme creation, editing (with live preview), and deletion in
- [ ] Cross-browser testing (if UI changes) - (Please specify browsers tested if applicable)
- [ ] Mobile responsiveness verified (if UI changes) - (Theme settings page/editor might need specific mobile testing)
Security Considerations
For changes involving data or authentication:
- [x] No sensitive data is exposed (Theme settings are generally cosmetic)
- [x] Authentication checks are in place (Server actions verify user session before performing theme operations)
- [x] Input validation is implemented (Basic validation via types, further sanitization might be needed for image URLs/gradients)
- [ ] Rate limiting is considered (if applicable) - (Not implemented, potentially needed for public theme creation/sharing)
Checklist
- [x] I have read the CONTRIBUTING document
- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in complex areas
- [ ] I have updated the documentation - (Documentation needs update for the new theme system)
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix/feature works - (No automated tests added)
- [x] All tests pass locally - (Assuming manual tests pass)
- [x] Any dependent changes are merged and published
Additional Notes
- This implementation adds theme selection/application primarily through the
/settings/themespage for the active connection. The original requirement to add theme selection directly to the connection setup screen is not included here and could be a separate enhancement. - The system currently uses general theme colors (
muted,accent, etc.) for the sidebar. If independent sidebar theming is desired in the future, theThemeSettingsschema andCustomThemeProviderwill need updates to handle specific--sidebar-*variables.
Screenshots/Recordings
https://github.com/user-attachments/assets/23d7d5a4-c984-412e-b377-e3112fc67adc
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
@umarhadi is attempting to deploy a commit to the Zero Team on Vercel.
A member of the Team first needs to authorize it.
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
~wrong base branch, sorry, ill do it again~
done
any update of this? @ahmetskilinc @MrgSub
@BlankParticle please review trpc usage
@BlankParticle please review trpc usage
still making up own hooks using the base trpc client instead of just using the integrated useTrpc hook and using the auto generated queryQptions from that