Zero icon indicating copy to clipboard operation
Zero copied to clipboard

Fixed: Issue#869 - scrollbar in sidebar

Open AbhiArya20 opened this issue 7 months ago • 6 comments

Description

Previously, the sidebar was not fully visible on certain screen sizes or when the browser was zoomed in, preventing users from accessing all sidebar items. This update adds a vertical scrollbar to the sidebar, ensuring that all content remains accessible regardless of screen size or zoom level.

Closes #869


Type of Change

Please delete options that are not relevant.

  • [x] 🐛 Bug fix (non-breaking change which fixes an issue)
  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [x] 🎨 UI/UX improvement

Areas Affected

  • [x] User Interface/Experience

Testing Done

  • [x] Cross-browser testing (if UI changes)
  • [x] Mobile responsiveness verified (if UI changes)

Checklist

  • [x] My code follows the project's style guidelines
  • [x] I have performed a self-review of my code
  • [x] My changes generate no new warnings

https://github.com/user-attachments/assets/8c15a133-97d2-4c71-87d2-2f50fddbd2a7

Summary by CodeRabbit

  • Refactor
    • Simplified and improved sidebar layout for better consistency and cleaner structure, including more consistent padding and scrollbar styling.
  • Style
    • Enhanced sidebar scrollbar appearance and adjusted responsive padding for improved visual experience.
  • Chores
    • Added and configured the Tailwind Scrollbar plugin for custom scrollbar styling.

AbhiArya20 avatar May 05 '25 17:05 AbhiArya20

@AbhiArya20 is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 05 '25 17:05 vercel[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update refactors the sidebar layout in the mail application by simplifying the structure, removing unnecessary wrapper elements, and consolidating the bottom section into a new SidebarFooter component. Padding and scrollbar styling are now conditionally applied directly to sidebar components based on the collapsed state. The update also enhances scrollbar styling by adding the tailwind-scrollbar plugin to the Tailwind CSS configuration and adjusting relevant dependencies. Minor responsive padding adjustments are made in the navigation component to improve layout consistency.

Changes

File(s) Change Summary
apps/mail/components/ui/app-sidebar.tsx Refactored sidebar layout, removed wrapper <div> elements, consolidated bottom section into SidebarFooter, and applied conditional padding and scrollbar styles directly to sidebar sections.
apps/mail/components/ui/nav-main.tsx Added responsive padding class (md:px-0) to SidebarGroup for improved layout on various screen sizes.
apps/mail/package.json Added tailwind-scrollbar v3.1.0 to devDependencies.
apps/mail/tailwind.config.ts Added and configured tailwind-scrollbar plugin for custom scrollbar styling in Tailwind CSS.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AppSidebar
    participant SidebarHeader
    participant SidebarContent
    participant SidebarFooter

    User->>AppSidebar: Render sidebar (collapsed/expanded)
    AppSidebar->>SidebarHeader: Render header with conditional padding
    AppSidebar->>SidebarContent: Render content with scrollbar and padding
    AppSidebar->>SidebarFooter: Render footer with modal and nav items, conditional padding

Assessment against linked issues

Objective Addressed Explanation
Add scrollbar or collapsible behavior to sidebar to ensure full visibility at 100% zoom (#869)

Possibly related PRs

  • Mail-0/Zero#836: Refactors sidebar layout and padding, related due to overlapping modifications to sidebar structure and styling.
  • Mail-0/Zero#828: Adjusts sidebar padding and layout, related as both PRs focus on sidebar layout refinements.
  • Mail-0/Zero#467: Modifies SidebarContent styling, directly related to sidebar layout and overflow handling.

Suggested reviewers

  • ahmetskilinc
  • needleXO

Poem

A sidebar once cluttered, now sleek and refined,
With scrollbars that shimmer and padding aligned.
Wrappers removed, the layout set free,
Footer and header in pure harmony.
Tailwind’s scrollbars now glide with flair—
A rabbit’s delight for users everywhere!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 05 '25 17:05 coderabbitai[bot]

Please rebase on staging and add images/video

MrgSub avatar May 05 '25 18:05 MrgSub

Hi @AbhiArya20 I switched the base to staging please use staging for all future pull requests. There are also some conflicts now. Please resolve those.

ahmetskilinc avatar May 07 '25 11:05 ahmetskilinc

@MrgSub @ahmetskilinc

I've added the video and resolved the conflict.

I'll make sure to use the staging branch for future PRs.

AbhiArya20 avatar May 07 '25 19:05 AbhiArya20

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
0 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 5:02pm

vercel[bot] avatar May 09 '25 17:05 vercel[bot]