Zero icon indicating copy to clipboard operation
Zero copied to clipboard

feat(mail): add clean email content copy button - Add copy button to …

Open R44VC0RP opened this issue 7 months ago • 6 comments

Description

Added a new feature to copy email content cleanly from the email display. This adds a copy button next to the AI summary button that extracts only the relevant text content from HTML emails, removing any CSS, template code, or invisible characters. The feature includes visual feedback (checkmark icon) when copying is successful and preserves email metadata like subject and sender information in the copied text.

This feature was implemented with AI assistance (Claude). The code has been carefully reviewed and tested to ensure:

  • Proper HTML sanitization using DOMPurify
  • Clean text extraction without template/styling code
  • Proper handling of email metadata
  • Accessibility and UX best practices
  • Type safety with TypeScript

Type of Change

  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [x] 🎨 UI/UX improvement

Areas Affected

  • [x] User Interface/Experience
  • [x] Email Integration (Gmail, IMAP, etc.)

Testing Done

  • [x] Manual testing performed
    • Tested with various email formats
    • Verified clean text extraction
    • Checked metadata inclusion
    • Tested copy feedback
  • [x] Cross-browser testing (if UI changes)
    • Tested in Chrome, Firefox, Safari
    • Verified clipboard API functionality
  • [x] Mobile responsiveness verified (if UI changes)
    • Confirmed button placement and visibility
    • Tested touch interaction

Security Considerations

  • [x] No sensitive data is exposed
    • Uses DOMPurify for HTML sanitization
    • Only copies visible email content
  • [x] Input validation is implemented
    • Validates email data before processing
    • Handles missing/null cases gracefully

Checklist

  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in complex areas
  • [x] My changes generate no new warnings
  • [x] My code follows the project's style guidelines
    • Uses Tailwind for styling
    • Follows TypeScript conventions
    • Maintains existing component patterns

Additional Notes

The copy functionality uses the native Clipboard API and includes fallback handling. The implementation carefully considers email content structure to preserve readability while removing unnecessary markup and styling.

Screenshots/Recordings

[Add screenshots showing:

  1. Copy button placement
  2. Copy feedback animation
  3. Example of copied text format]

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • New Features
    • Introduced a convenient copy-to-clipboard option for email content, including subject and sender details, with dynamic visual feedback.
    • Enhanced the display of recipient fields to ensure accurate and reliable rendering.

R44VC0RP avatar Apr 09 '25 20:04 R44VC0RP

@R44VC0RP is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 09 '25 20:04 vercel[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change integrates a clipboard copy feature into the mail display component. A new function, copyEmailContent, sanitizes the email content using DOMPurify and formats it with subject and sender details before copying. An accompanying state variable, isCopied, manages the visual feedback on success. Additionally, the rendering logic for the cc field is refined to ensure correct conditional display.

Changes

File(s) Summary
apps/mail/components/mail/mail-display.tsx Added copyEmailContent function to sanitize and format email content for clipboard copying. Introduced isCopied state to manage UI feedback and added a copy button with conditional icon update. Adjusted cc field rendering logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MailDisplay
    participant DOMPurify

    User->>MailDisplay: Clicks "Copy" Button
    MailDisplay->>DOMPurify: Call sanitization on email HTML
    DOMPurify-->>MailDisplay: Returns sanitized text
    MailDisplay->>MailDisplay: Format content with subject and sender
    MailDisplay->>MailDisplay: Set isCopied state to true
    MailDisplay-->>User: Update UI feedback with icon change

Suggested reviewers

  • MrgSub

Poem

I hopped through lines of code so neat,
Adding a copy feature as a sweet treat,
With DOMPurify cleaning the HTML mess,
"isCopied" shines when the copy is a success,
From a rabbit’s burrow, these changes do gleam,
A playful nibble on code, like a dream.
🐇


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 09 '25 20:04 coderabbitai[bot]

did we want to add this, I feel like @MrgSub said something but I cannot remember where he said it

R44VC0RP avatar Apr 10 '25 20:04 R44VC0RP

:white_check_mark: Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar Apr 10 '25 21:04 coderabbitai[bot]

@R44VC0RP Hello Mr. Vogel - can you merge latest staging? I want to test this

ahmetskilinc avatar Apr 24 '25 12:04 ahmetskilinc

lemme figure out how to do that @ahmetskilinc

give me a bit

R44VC0RP avatar Apr 24 '25 13:04 R44VC0RP