Zero icon indicating copy to clipboard operation
Zero copied to clipboard

feat: Draft mail list timming display added

Open samrathreddy opened this issue 6 months ago • 1 comments

Description

Added time display to the draft mail list, similar to inbox mail recieved on time.


Type of Change

Please delete options that are not relevant.

  • [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature with breaking changes)
  • [ ] 📝 Documentation update
  • [x] 🎨 UI/UX improvement
  • [ ] 🔒 Security enhancement
  • [ ] ⚡ Performance improvement

Areas Affected

Please check all that apply:

  • [ ] Email Integration (Gmail, IMAP, etc.)
  • [x] User Interface/Experience
  • [ ] Authentication/Authorization
  • [ ] Data Storage/Management
  • [ ] API Endpoints
  • [ ] Documentation
  • [ ] Testing Infrastructure
  • [ ] Development Workflow
  • [ ] Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • [ ] Unit tests added/updated
  • [ ] Integration tests added/updated
  • [ ] Manual testing performed
  • [x] Cross-browser testing (if UI changes)
  • [x] Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • [ ] No sensitive data is exposed
  • [ ] Authentication checks are in place
  • [ ] Input validation is implemented
  • [ ] Rate limiting is considered (if applicable)

Checklist

  • [ ] I have read the CONTRIBUTING document
  • [x] My code follows the project's style guidelines
  • [x] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in complex areas
  • [ ] I have updated the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix/feature works
  • [ ] All tests pass locally
  • [ ] Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Before: Screenshot 2025-06-27 at 1 11 40 AM

After: Screenshot 2025-06-27 at 1 11 29 AM


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • New Features

    • Draft emails now display their internal date, if available, in the draft list for easier reference.
  • Improvements

    • Enhanced date formatting to support timestamps, ensuring consistent display of dates across the app.

samrathreddy avatar Jun 26 '25 20:06 samrathreddy

Walkthrough

This change updates the mail draft list UI to conditionally display the draft's internal date if available, using a formatted date string. It also extends the formatDate utility to accept numeric timestamps, ensuring consistent date formatting across different input types.

Changes

File(s) Change Summary
apps/mail/components/mail/mail-list.tsx Adds conditional rendering to show draft internal date using formatDate if internalDate exists.
apps/mail/lib/utils.ts Overloads and extends formatDate to support numeric timestamps; updates function signatures.

Sequence Diagram(s)

sequenceDiagram
    participant DraftComponent
    participant Utils

    DraftComponent->>DraftComponent: Check if draft.rawMessage?.internalDate exists
    alt internalDate exists
        DraftComponent->>Utils: formatDate(Number(internalDate))
        Utils-->>DraftComponent: Formatted date string
        DraftComponent->>DraftComponent: Render formatted date in UI
    else internalDate missing
        DraftComponent->>DraftComponent: Do not render date
    end

Possibly related PRs

  • Mail-0/Zero#1302: Adds skeleton loader for drafts when data is unavailable, also modifies the Draft component but focuses on loading states rather than date display.

Suggested labels

Low Priority

Suggested reviewers

  • MrgSub

Poem

In the drafts where emails wait,
A date now peeks—oh, isn’t that great?
With numbers or strings, the formatter’s wise,
Showing time’s passage with gentle surprise.
The bunny hops on, with code so neat,
Bringing clarity to every sent and unsent sheet!
🐇📬

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 26 '25 20:06 coderabbitai[bot]