Zero icon indicating copy to clipboard operation
Zero copied to clipboard

resolve inconsistencies in translation usage

Open abhix4 opened this issue 6 months ago β€’ 1 comments

Description

fix the categories label translations and more on thread display.


Type of Change

Please delete options that are not relevant.

  • [x] πŸ› Bug fix (non-breaking change which fixes an issue)
  • [ ] ✨ New feature (non-breaking change which adds functionality)
  • [ ] πŸ’₯ Breaking change (fix or feature with breaking changes)
  • [ ] πŸ“ Documentation update
  • [ ] 🎨 UI/UX improvement
  • [ ] πŸ”’ Security enhancement
  • [ ] ⚑ Performance improvement

Areas Affected

Please check all that apply:

  • [ ] Email Integration (Gmail, IMAP, etc.)
  • [ ] User Interface/Experience
  • [ ] Authentication/Authorization
  • [ ] Data Storage/Management
  • [ ] API Endpoints
  • [ ] Documentation
  • [ ] Testing Infrastructure
  • [ ] Development Workflow
  • [ ] Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • [ ] Unit tests added/updated
  • [ ] Integration tests added/updated
  • [ ] Manual testing performed
  • [ ] Cross-browser testing (if UI changes)
  • [ ] Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • [ ] No sensitive data is exposed
  • [ ] Authentication checks are in place
  • [ ] Input validation is implemented
  • [ ] Rate limiting is considered (if applicable)

Checklist

  • [x] I have read the CONTRIBUTING document
  • [x] My code follows the project's style guidelines
  • [x] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in complex areas
  • [ ] I have updated the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix/feature works
  • [x] All tests pass locally
  • [ ] Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Add screenshots or recordings here if applicable.


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • New Features

    • Added support for internationalization of various UI text elements in the mail application, including button labels and menu items.
    • Enhanced translation handling for category names in the mail interface.
  • Bug Fixes

    • Improved fallback behavior for untranslated category names.
  • Documentation

    • Updated English locale with new translation keys for "Print" and "Print thread".

abhix4 avatar Jun 26 '25 16:06 abhix4

Walkthrough

This update replaces hardcoded English UI text in mail-related components with translation function calls for internationalization. It also adjusts the logic for generating translation keys for mail categories and adds new translation keys to the English locale JSON file. No exported interfaces or control flow are changed.

Changes

File(s) Change Summary
apps/mail/components/mail/mail-display.tsx Replaced hardcoded text ("Details", "Print", "To:") with translation function calls.
apps/mail/components/mail/thread-display.tsx Replaced hardcoded text ("Reply All", "Print thread", "Unsubscribe") with translation function calls.
apps/mail/components/mail/mail.tsx Changed category translation key construction logic in the Categories component.
apps/mail/locales/en.json Added new translation keys: mailDisplay.print and threadDisplay.printThread.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UIComponent
    participant TranslationModule

    User->>UIComponent: Interacts with mail UI (e.g., opens details, prints, replies)
    UIComponent->>TranslationModule: Requests localized string via t('key')
    TranslationModule-->>UIComponent: Returns localized string
    UIComponent-->>User: Displays localized UI text

Possibly related PRs

  • Mail-0/Zero#1172: Modifies the Categories component to improve internationalization by changing how category names are translated.
  • Mail-0/Zero#440: Updates localization JSON files with translated strings for various languages, related through localization efforts.
  • Mail-0/Zero#597: Modifies the ThreadDisplay component, but focuses on new props and actions rather than just translation.

Suggested reviewers

  • ahmetskilinc

Poem

In the garden of code, where translations bloom,
Hardcoded words now make roomβ€”
For every language, near and far,
UI sings like a global star.
With every string now set to roam,
The inbox feels a bit more like home!
πŸ‡πŸŒβœ¨

✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 26 '25 16:06 coderabbitai[bot]