Zero icon indicating copy to clipboard operation
Zero copied to clipboard

feat: show sender details with copy email option in mail sender popover

Open abhix4 opened this issue 7 months ago β€’ 2 comments

Description

  • Display avatar in the popover
  • Add "copy to clipboard" functionality for sender email

Type of Change

Please delete options that are not relevant.

  • [ ] πŸ› Bug fix (non-breaking change which fixes an issue)
  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [ ] πŸ’₯ Breaking change (fix or feature with breaking changes)
  • [ ] πŸ“ Documentation update
  • [x] 🎨 UI/UX improvement
  • [ ] πŸ”’ Security enhancement
  • [ ] ⚑ Performance improvement

Areas Affected

Please check all that apply:

  • [ ] Email Integration (Gmail, IMAP, etc.)
  • [ ] User Interface/Experience
  • [ ] Authentication/Authorization
  • [ ] Data Storage/Management
  • [ ] API Endpoints
  • [ ] Documentation
  • [ ] Testing Infrastructure
  • [ ] Development Workflow
  • [ ] Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • [ ] Unit tests added/updated
  • [ ] Integration tests added/updated
  • [ ] Manual testing performed
  • [x] Cross-browser testing (if UI changes)
  • [x] Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • [ ] No sensitive data is exposed
  • [ ] Authentication checks are in place
  • [ ] Input validation is implemented
  • [ ] Rate limiting is considered (if applicable)

Checklist

  • [x] I have read the CONTRIBUTING document
  • [x] My code follows the project's style guidelines
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in complex areas
  • [ ] I have updated the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix/feature works
  • [ ] All tests pass locally
  • [ ] Any dependent changes are merged and published

Additional Notes

There should be a send email option directly from the popover . what do you think @MrgSub

Screenshots/Recordings

Before: Screenshot from 2025-06-17 17-09-39

After: Screencast from 2025-06-17 17-38-06.webm


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • New Features

    • Added the ability to quickly copy a sender's email address to the clipboard using a copy icon in the sender popover.
  • Style

    • Improved the sender popover with a larger avatar, enhanced layout, and better presentation of sender details. The copy icon is now only visible on hover for a cleaner look.

abhix4 avatar Jun 17 '25 12:06 abhix4

"""

Walkthrough

A new callback for copying a sender's email address to the clipboard was added to the mail display component. The sender popover was enhanced with a larger avatar, improved layout, and a copy icon next to the email, which appears on hover and triggers the clipboard copy functionality.

Changes

File(s) Change Summary
apps/mail/components/mail/mail-display.tsx Added handleCopySenderEmail callback; enhanced sender popover with larger avatar, new layout, and copy-to-clipboard icon for email.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MailDisplay
    participant ClipboardAPI

    User->>MailDisplay: Hover over sender
    MailDisplay->>User: Show popover with avatar, name, email, and copy icon
    User->>MailDisplay: Click copy icon
    MailDisplay->>ClipboardAPI: Copy sender email to clipboard
    ClipboardAPI-->>MailDisplay: Success/Failure (not shown to user)

Possibly related PRs

  • Mail-0/Zero#722: Both PRs modify the sender's email rendering in the mail details popover, with this PR adding copy-to-clipboard and layout improvements, and the related PR addressing duplicate email display.
  • Mail-0/Zero#528: Related by component, this PR modifies avatar rendering logic in the MailDisplay component without overlapping the copy-to-clipboard or popover content changes.

Suggested reviewers

  • ahmetskilinc
  • MrgSub

Poem

In the mailbox where messages dwell,
A sender's email now copies well.
With a click on a bunny-bright icon,
The address hops to your clipboard, gone!
Avatars grow, layouts shineβ€”
Rabbits rejoice in code divine.
πŸ‡βœ¨ """


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 5aaca3b2f10266b07e7cf9d65d4add5d7ea17aba and 9f4b2d51e3551da838e430ba9b1bbe77e7d5529b.

πŸ“’ Files selected for processing (1)
  • apps/mail/components/mail/mail-display.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/mail/components/mail/mail-display.tsx
✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 17 '25 12:06 coderabbitai[bot]

one comment added

@ahmetskilinc Changes addressed. Let me know if anything else looks off!

abhix4 avatar Jun 17 '25 14:06 abhix4