Delete Draft

[Adarsh9977]

Aded delete draft functionality

This PR fix/complete https://feedback.0.email/p/unable-to-delete-draft-emails-in-zero-client

• After

https://github.com/user-attachments/assets/e809195f-527f-47ee-b1b5-32a287dde0ca

Summary by CodeRabbit

• New Features

  • Added the ability to delete draft emails, including support for bulk deletion.
  • Introduced a context menu for draft items with a delete option.
  • Drafts now disappear instantly upon deletion for a smoother user experience.

• Bug Fixes

  • Draft UI correctly hides when a draft is deleted.

• Localization

  • Added a new label for the delete draft action to the English locale.

• Configuration

  • Introduced an environment variable to enable or disable draft deletion functionality.

[coderabbitai[bot]]

"""

Walkthrough

This change introduces optimistic deletion for draft emails in a mail application. It adds a context menu for drafts with a delete option, updates hooks and state management to support optimistic deletion, extends backend interfaces and APIs to handle draft deletions, and updates localization for the new action. Both single and bulk draft deletions are supported.

Changes

File(s)	Change Summary
apps/mail/components/context/draft-context.tsx	Added DraftContextMenu component for draft context menu with delete action.
apps/mail/components/mail/mail-list.tsx	Wrapped draft display in DraftContextMenu; conditional rendering for optimistic UI; removed AnimatePresence.
apps/mail/components/mail/optimistic-thread-state.tsx	Added 'DELETE' action handling to useOptimisticThreadState for hiding/removing drafts optimistically.
apps/mail/hooks/use-optimistic-actions.ts	Added optimistic draft deletion logic, new PendingAction type, optimisticDeleteDrafts function.
apps/mail/store/optimistic-updates.ts	Extended OptimisticAction type to include 'DELETE' for threads.
apps/mail/locales/en.json	Added "deleteDraft" shortcut label to English locale.
apps/server/src/lib/driver/google.ts	Added deleteDraft method to GoogleMailManager for Gmail draft deletion.
apps/server/src/lib/driver/types.ts	Added deleteDraft method to MailManager interface.
apps/server/src/trpc/routes/mail.ts	Added bulkDeleteDraft mutation procedure for deleting multiple drafts.
apps/mail/lib/optimistic-actions-manager.ts	Extended PendingAction type to include 'DELETE' action variant.
.env.example	Added environment variable VITE_PUBLIC_IS_DRAFT_DELETE_ENABLED=true.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DraftContextMenu
    participant useOptimisticActions
    participant BackendAPI
    participant MailManager

    User->>DraftContextMenu: Right-click draft, select "Delete"
    DraftContextMenu->>useOptimisticActions: optimisticDeleteDrafts([draftId])
    useOptimisticActions->>useOptimisticThreadState: Set shouldHide, isRemoving = true
    useOptimisticActions->>BackendAPI: Call bulkDeleteDraft([draftId])
    BackendAPI->>MailManager: deleteDraft(draftId)
    MailManager-->>BackendAPI: Deletion result
    BackendAPI-->>useOptimisticActions: Success/Failure response
    useOptimisticActions->>useOptimisticThreadState: Finalize optimistic state

Possibly related PRs

• Mail-0/Zero#1302: Adds a skeleton loader placeholder for drafts without modifying draft rendering logic or adding context menu or deletion features; related to draft rendering but addresses different aspects.

Suggested reviewers

• ahmetskilinc
• MrgSub

Poem

A draft once lingered, soon to be gone,
With a right-click menu, we move it along.
Optimistic bunnies, quick to erase,
Backend and frontend, both keep the pace.
"Delete!" cries the shortcut, with nary a fuss—
Now the drafts are all hopping off,
Leaving more inbox space for us! 🐇✨ """

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85df7e636183913d4fa62e66b578f81bc0674364 and 3f86053bd142bbdcac7aaf18107cf539bf23b5cd.

📒 Files selected for processing (1)

• apps/mail/components/mail/mail-list.tsx (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/mail/components/mail/mail-list.tsx

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Adarsh9977]

Hey great pr. I left 1 comment.

Thank you @ahmetskilinc, fixed the requested changes. Please let me know if any update needed

[MrgSub]

Merge activity

• Jun 10, 2:11 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 10, 2:11 AM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

[Adarsh9977]

@MrgSub ready to merge!

[Adarsh9977]

@MrgSub Added the flag in env and tested. Working fine as expected.

[Adarsh9977]

@MrgSub please take a look

[github-actions[bot]]

This PR has merge conflicts and has been open for more than 3 days. It will be automatically closed. Please resolve the conflicts and reopen the PR if you'd like to continue working on it.