flutter_local_notifications icon indicating copy to clipboard operation
flutter_local_notifications copied to clipboard

Support for Android 13 Tiramisu (API 33)

Open bartekpacia opened this issue 3 years ago • 9 comments

Android 13 introduces new runtime permission for notifications.

I've looked but haven't found any mention about it in the package's README on pub.dev.

So I suggest that AndroidFlutterPluginImplementation should get requestPermissions method, similar to iOSFlutterPluginImplementation

bartekpacia avatar May 16 '22 11:05 bartekpacia

Thanks for raising this. Do you think could you submit a PR for this? One thing I'm also wondering is given how Android 13 appears to be in beta, I assume that making a stable release of the plugin depend on the Android 13 SDK isn't the way to go as this could cause issues for that don't have the SDK, which in turn requires a preview version of Android Studio. Is this right? If so, I suppose that support for this would require being in a pre-release so it's up to developers to opt-in with using the functionality just as they would do for using an SDK in preview?

MaikuB avatar May 19 '22 04:05 MaikuB

Hi @MaikuB 👋

Yes, I'd be very happy to submit a PR for this. Unfortunately I've encountered problems at the very beginning. Looks like Flutter (flutter_tools, to be precise) can't build apps that target Tiramisu.

I've submitted an issue about this in flutter/flutter. I think we'll have to wait until it's resolved before we can start working on this (new notification permission) feature.

bartekpacia avatar May 19 '22 10:05 bartekpacia

Much appreciated. Though the other thing is the SDK itself has various milestones so it may still bit too early to look at. There tends to be a beta where Google states that the APIs are final and and the SDK can be referenced by API level instead of the codename, which in itself is like a breaking change

MaikuB avatar May 19 '22 11:05 MaikuB

There tends to be a beta where Google states that the APIs are final and and the SDK can be referenced by API level instead of the codename

Yeah, it's called platform stability phase.

Screenshot 2022-05-19 at 1 09 01 PM

Still, I'd like to be able to target Flutter apps on non-stable-yet platforms (i.e referenced by codenames). Let's wait until some Flutter team member answers to that issue and see what they say.

Summing up, I guess that the action item here is to wait until Google declares platform stability :)

bartekpacia avatar May 19 '22 11:05 bartekpacia

Any updates? Platform stability has been reached.

ciriousjoker avatar Jul 05 '22 06:07 ciriousjoker

I think API 33 is already available

Cubel89 avatar Jul 28 '22 11:07 Cubel89

Yeah, it is.

bartekpacia avatar Jul 28 '22 12:07 bartekpacia

If no one's interested in doing this, I volunteer. I'd like to get this done over the next few days. Can you assign me @MaikuB?

bartekpacia avatar Jul 28 '22 12:07 bartekpacia

@bartekpacia Much appreciated! Maybe this link will also be helpful here: https://blog.esper.io/android-13-exact-alarm-api-restrictions/

mk-dev-1 avatar Jul 29 '22 07:07 mk-dev-1

@MaikuB Can we prioritize @bartekpacia's pull request?

Android 13 is publicly available out on Pixels now: https://www.theverge.com/2022/8/15/23306058/android-13-release-date-pixel-devices-features

stephanie-finch avatar Aug 16 '22 22:08 stephanie-finch