codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

Overhaul the Suspicious Metrics menu with Angular-17

Open ViktoriaGordeevaVG opened this issue 1 year ago • 3 comments

Overhaul the Suspicious Metrics menu

Closes: #3493

Description

The 'Suspicious Metrics' tab has been streamlined and is now more user-friendly. Key improvements include:

  • Information about suspicious metrics is neatly concealed within an info box, accessible via click or hover for easy visibility.
  • Untracked metrics in the code are now neatly tucked away in a toggle feature, which can be expanded with a click, similar to the functionality of our file explorer.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • [X] Changes have been manually tested
  • [X] All TODOs related to this PR have been closed
  • [X] There are automated tests for newly written code and bug fixes
  • [X] All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • [X] Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • [X] CHANGELOG.md has been updated

ViktoriaGordeevaVG avatar May 08 '24 10:05 ViktoriaGordeevaVG

image

We should probably improve a couple of things:

  • [x] Make Suspicious Metrics at the top a bit bigger so that it's a heading for the whole Metrics part
  • [x] reduce space between "Suspicious Metrics" and "Suspicious Metrics in ts code"
  • [ ] if easily achievable, animate the arrow from accordions
  • [x] reduce space between accordions to their content like "Unsuspcious metrics in ts code"
  • [x] remove one level of idention of unsuspicious and untracked metricks so it feels like the following example:

Suspicious Metrics (h1) Suspicious Metrics in ts code (h2 - identation 0) Unsuspicious metrics in ts code (h2 - identation from 1 to 0) Untracked metrics in ts code (h2 - identation from 1 to 0)

h1 and h2 are just examples. Use an appropriate level so that h1 feels like a header and h2 like headers for categories inside. 👍

ChristianHuehn avatar May 10 '24 08:05 ChristianHuehn

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 13 '24 11:05 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 03 '24 11:06 sonarqubecloud[bot]