codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

Improve floor label algorithm for d3 hierarchy

Open RomanenkoVladimir opened this issue 2 years ago • 0 comments

Feature request

Description

As a user, I want to visualize maps with many folder labels, without them getting too long

Acceptance criteria

  • Maps with folder labels are rendered
  • No buildings disappear due to folder labels
  • Text of folder labels is big enough to be readable

Development notes (optional Task Breakdown)

  • [ ] Implement a way to recognize floor labels that are too small to render
  • [ ] Change current calculation to account for visualized labels
  • [ ] Change folder sizes to achieve a rectangle map

Open questions

  • Passing an algorithm to marginRight() (which is what we use for folder labels) is currently not supported by d3-hierarchy
    • We could either try to re-implement the feature, fork the hierarchy library or create an official feature PR

Connected to #1609 and #3044

RomanenkoVladimir avatar Oct 07 '22 15:10 RomanenkoVladimir