codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard
verified publisher icon MaibornWolff

Refactor/2318/migrate presentation mode button

Open shaman-apprentice opened this issue 3 years ago • 3 comments

shaman-apprentice avatar Aug 04 '22 08:08 shaman-apprentice

  • [x] add changelog
  • [x] make prettier happy again
  • [x] font and capital as "Global Configuration"

shaman-apprentice avatar Aug 04 '22 08:08 shaman-apprentice

Is it intentional that this is still a draft?

BridgeAR avatar Aug 29 '22 12:08 BridgeAR

Is it intentional that this is still a draft?

@BridgeAR No! Thanks for mentioning. Now it's ready to review.

electricbrick42 avatar Aug 30 '22 07:08 electricbrick42

Be careful to not produce to "Chore" sections in changelog when merging main ;)

LGTM. Thanks for the completion @electricbrick42 ! As I opened this PR for you I cannot approve. Otherwise I would ;) Can you approve for me and merge please? :)

@shaman-apprentice You're welcome! :) I already did produce a "Chore" section for my own changelog entry, but I assume that's not what you meant?

electricbrick42 avatar Aug 30 '22 09:08 electricbrick42

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 30 '22 09:08 sonarqubecloud[bot]

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 30 '22 09:08 sonarqubecloud[bot]